Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: client/tests/client/html/DocumentFragmentTests.dart

Issue 9610011: Port DocumentFragment to the new wrapperless DOM. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Merge with head Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/html/src/shared_FactoryProviders.dart ('k') | client/tests/client/html/html_tests.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/tests/client/html/DocumentFragmentTests.dart
diff --git a/client/tests/client/html/DocumentFragmentTests.dart b/client/tests/client/html/DocumentFragmentTests.dart
index 3425beda94e11ae62668165790da69d11b6f5d8a..a4981716151c721909725c81e85178202f1a125f 100644
--- a/client/tests/client/html/DocumentFragmentTests.dart
+++ b/client/tests/client/html/DocumentFragmentTests.dart
@@ -37,9 +37,13 @@ testDocumentFragment() {
// Expect.isNull(style.getPropertyCSSValue('color'));
// Expect.isNull(style.getPropertyShorthand('color'));
// Expect.isFalse(style.isPropertyImplicit('color'));
- expectUnsupported(() => style.cssText = '* {color: blue}');
- expectUnsupported(() => style.removeProperty('color'));
- expectUnsupported(() => style.setProperty('color', 'blue'));
+
+ // Ideally these would throw errors, but it's not possible to create a class
+ // that'll intercept these calls without implementing the entire
+ // CSSStyleDeclaration interface, so we'll settle for them being no-ops.
+ style.cssText = '* {color: blue}';
+ style.removeProperty('color');
+ style.setProperty('color', 'blue');
}
group('constructors', () {
@@ -53,10 +57,10 @@ testDocumentFragment() {
Expect.isTrue(fragment.elements.first is AnchorElement);
});
- test('.svg parses input as SVG', () {
- final fragment = new DocumentFragment.svg('<a>foo</a>');
- Expect.isTrue(fragment.elements.first is SVGAElement);
- });
+ // test('.svg parses input as SVG', () {
+ // final fragment = new DocumentFragment.svg('<a>foo</a>');
+ // Expect.isTrue(fragment.elements.first is SVGAElement);
+ // });
});
test('Unsupported operations throw errors', () {
@@ -75,9 +79,11 @@ testDocumentFragment() {
expectUnsupported(() => emptyFragment.scrollLeft = 10);
expectUnsupported(() => emptyFragment.scrollTop = 10);
expectUnsupported(() => emptyFragment.spellcheck = true);
+ expectUnsupported(() => emptyFragment.translate = true);
expectUnsupported(() => emptyFragment.tabIndex = 5);
expectUnsupported(() => emptyFragment.title = "foo");
expectUnsupported(() => emptyFragment.webkitdropzone = "foo");
+ expectUnsupported(() => emptyFragment.webkitRegionOverflow = "foo");
});
group('elements', () {
@@ -263,9 +269,11 @@ testDocumentFragment() {
fragment.on.click.add((e) => null);
fragment.blur();
fragment.focus();
+ fragment.click();
fragment.scrollByLines(2);
fragment.scrollByPages(2);
fragment.scrollIntoView();
+ fragment.webkitRequestFullScreen(2);
});
asyncTest('default values', 1, () {
@@ -284,10 +292,12 @@ testDocumentFragment() {
Expect.equals("", fragment.title);
Expect.equals("", fragment.tagName);
Expect.equals("", fragment.webkitdropzone);
+ Expect.equals("", fragment.webkitRegionOverflow);
Expect.isFalse(fragment.isContentEditable);
Expect.isFalse(fragment.draggable);
Expect.isFalse(fragment.hidden);
Expect.isFalse(fragment.spellcheck);
+ Expect.isFalse(fragment.translate);
Expect.isNull(fragment.nextElementSibling);
Expect.isNull(fragment.previousElementSibling);
Expect.isNull(fragment.offsetParent);
@@ -309,13 +319,6 @@ testDocumentFragment() {
});
});
- test('setters throw errors', () {
- var style = new DocumentFragment().style;
- expectUnsupported(() => style.cssText = '* {color: blue}');
- expectUnsupported(() => style.removeProperty('color'));
- expectUnsupported(() => style.setProperty('color', 'blue'));
- });
-
// TODO(nweiz): re-enable when const is better supported in dartc and/or frog
// test('const fields are immutable', () {
// var fragment = new DocumentFragment();
« no previous file with comments | « client/html/src/shared_FactoryProviders.dart ('k') | client/tests/client/html/html_tests.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698