Port DocumentFragment to the new wrapperless DOM.

client/tests/client/html/DocumentFragmentTests.dart

Index: client/tests/client/html/DocumentFragmentTests.dart
diff --git a/client/tests/client/html/DocumentFragmentTests.dart b/client/tests/client/html/DocumentFragmentTests.dart
index 3425beda94e11ae62668165790da69d11b6f5d8a..acd58aca11682c1de708af88390e8ba3627ee9bc 100644
--- a/client/tests/client/html/DocumentFragmentTests.dart
+++ b/client/tests/client/html/DocumentFragmentTests.dart
@@ -37,9 +37,12 @@ testDocumentFragment() {
     // Expect.isNull(style.getPropertyCSSValue('color'));
     // Expect.isNull(style.getPropertyShorthand('color'));
     // Expect.isFalse(style.isPropertyImplicit('color'));
-    expectUnsupported(() => style.cssText = '* {color: blue}');
-    expectUnsupported(() => style.removeProperty('color'));
-    expectUnsupported(() => style.setProperty('color', 'blue'));
+
+    // TODO(nweiz): is it possible to efficiently support a frozen style object
+    // in a wrapperless world?

[Jacob, 2012/03/06 05:09:00]

yes. just don't use a real style object and you'll be fine.  For example you
could a non-native class that inherits from a  native class but overrides
getValue.  Not sure if that is worthwhile though.  Doesn't seem like that
important a thing to enforce.

[nweiz, 2012/03/06 20:10:47]

I don't follow... how would you get an instance of a subclass of
CSSStyleDeclaration in a wrapperless world?

I think enforcing this is correct if we're enforcing that other meaningless
setters throw errors.

[Jacob, 2012/03/06 22:41:59]

You do it by

class _FrozenCSSStyleDeclation extends _CSSStyleDeclarationImpl {
  _FrozenCSSStyleDeclation() {
    ...
  }
  ....
}


new _FrozenCSSStyleDeclation()
I believe that works but sra can confirm whether that is a horrible thing to do.

I agree that enforcing this is correct but pragmatically speaking i think it
would be alright if we had to punt it if it is hard to do or makes the code
harder for the compiler optimize.

[nweiz, 2012/03/08 23:02:49]

Done.

[nweiz, 2012/03/08 23:52:47]

Actually, that doesn't work... Dart requires that you call the superclass
constructor, which isn't possible in a wrapperless world.

I think for now the thing to do is to allow property assignment to be a no-op.

+    // expectUnsupported(() => style.cssText = '* {color: blue}');
+    // expectUnsupported(() => style.removeProperty('color'));
+    // expectUnsupported(() => style.setProperty('color', 'blue'));
   }
 
   group('constructors', () {
@@ -53,10 +56,10 @@ testDocumentFragment() {
       Expect.isTrue(fragment.elements.first is AnchorElement);
     });
 
-    test('.svg parses input as SVG', () {
-      final fragment = new DocumentFragment.svg('<a>foo</a>');
-      Expect.isTrue(fragment.elements.first is SVGAElement);
-    });
+    // test('.svg parses input as SVG', () {
+    //   final fragment = new DocumentFragment.svg('<a>foo</a>');
+    //   Expect.isTrue(fragment.elements.first is SVGAElement);
+    // });
   });
 
   test('Unsupported operations throw errors', () {
@@ -309,13 +312,6 @@ testDocumentFragment() {
     });
   });
 
-  test('setters throw errors', () {
-    var style = new DocumentFragment().style;
-    expectUnsupported(() => style.cssText = '* {color: blue}');
-    expectUnsupported(() => style.removeProperty('color'));
-    expectUnsupported(() => style.setProperty('color', 'blue'));
-  });
-
   // TODO(nweiz): re-enable when const is better supported in dartc and/or frog
   // test('const fields are immutable', () {
   //   var fragment = new DocumentFragment();