Refactoring, moving and renaming the NetworkActionPredictor.

chrome/browser/predictors/autocomplete_action_predictor_table.h

Index: chrome/browser/predictors/autocomplete_action_predictor_table.h
diff --git a/chrome/browser/predictors/autocomplete_action_predictor_table.h b/chrome/browser/predictors/autocomplete_action_predictor_table.h
new file mode 100644
index 0000000000000000000000000000000000000000..d4e44bb75f1f5afb8da5c045aa6d9b0cca29de39
--- /dev/null
+++ b/chrome/browser/predictors/autocomplete_action_predictor_table.h
@@ -0,0 +1,90 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREDICTORS_AUTOCOMPLETE_ACTION_PREDICTOR_TABLE_H_
+#define CHROME_BROWSER_PREDICTORS_AUTOCOMPLETE_ACTION_PREDICTOR_TABLE_H_
+#pragma once
+
+#include <string>
+#include <vector>
+
+#include "base/string16.h"
+#include "chrome/browser/predictors/predictor_table_base.h"
+#include "googleurl/src/gurl.h"
+
+namespace predictors {
+
+// This manages the autocomplete predictor table within the SQLite database
+// passed in to the constructor. It expects the following scheme:
+//
+// network_action_predictor
+//   id                 A unique id.
+//   user_text          What the user typed.
+//   url                The URL of the entry.
+//   number_of_hits     Number of times the entry was shown to the user and
+//                      selected.
+//   number_of_misses   Number of times the entry was shown to the user but not
+//                      selected.
+//
+// TODO(dominich): Consider adding this table to one of the history databases.
+// In memory is currently used, but adding to the on-disk visits database
+// would allow DeleteOldEntries to be cheaper through use of a join.
+//
+// All the functions apart from constructor and destructor have to be called in
+// the DB thread.
+class AutocompleteActionPredictorTable : public PredictorTableBase {
+ public:
+  struct Row {
+    // TODO(dominich): Make this 64-bit integer as an optimization. This
+    // requires some investigation into how to make sure the id is unique for
+    // each user_text/url pair.
+    // http://crbug.com/102020
+    typedef std::string Id;
+
+    Row();
+
+    // Only used by unit tests.
+    Row(const Id& id,
+        const string16& user_text,
+        const GURL& url,
+        int number_of_hits,
+        int number_of_misses);
+
+    Row(const Row& row);
+
+    Id id;
+    string16 user_text;
+    GURL url;
+    int number_of_hits;
+    int number_of_misses;
+  };
+
+  typedef std::vector<Row> Rows;
+
+  // DB thread functions.
+  void GetRow(const Row::Id& id, Row* row);
+  void GetAllRows(Rows* row_buffer);
+  void AddRow(const Row& row);
+  void UpdateRow(const Row& row);
+  void AddAndUpdateRows(const Rows& rows_to_add, const Rows& rows_to_update);
+  void DeleteRow(const Row::Id& id);

[Scott Hess - ex-Googler, 2012/03/15 00:13:33]

AFAICT, DeleteRow() is only called from tests.

[Shishir, 2012/03/15 07:55:48]

Removed.

+  void DeleteRows(const std::vector<Row::Id>& id_list);
+  void DeleteAllRows();
+
+ private:
+  friend class PredictorDatabaseInternal;
+
+  AutocompleteActionPredictorTable();
+  virtual ~AutocompleteActionPredictorTable();
+
+  // PredictorTableBase methods (DB thread).
+  virtual void CreateTableIfNonExistent() OVERRIDE;
+  virtual void LogDatabaseStats() OVERRIDE;
+
+  DISALLOW_COPY_AND_ASSIGN(AutocompleteActionPredictorTable);
+};
+
+}  // namespace predictors
+
+#endif  // CHROME_BROWSER_PREDICTORS_AUTOCOMPLETE_ACTION_PREDICTOR_TABLE_H_