Issue 9609016: Initial cut at multi-window resize code. There's still some TODOs, but

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9609016: Initial cut at multi-window resize code. There's still some TODOs, but (Closed)

Created:
8 years, 9 months ago by sky

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Initial cut at multi-window resize code. There's still some TODOs, but this is enough for folks to get a feel for it. BUG=116079 TEST=covered by tests. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125187

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1190 lines, -59 lines)			Patch
M	ash/ash.gyp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/wm/root_window_event_filter.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	ash/wm/root_window_event_filter.cc	View		2 chunks	+25 lines, -24 lines	0 comments	Download
M	ash/wm/toplevel_window_event_filter_unittest.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
A	ash/wm/workspace/multi_window_resize_controller.h	View		1 chunk	+145 lines, -0 lines	1 comment	Download
A	ash/wm/workspace/multi_window_resize_controller.cc	View	1	1 chunk	+376 lines, -0 lines	0 comments	Download
M	ash/wm/workspace/workspace_event_filter.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	ash/wm/workspace/workspace_event_filter.cc	View		3 chunks	+11 lines, -1 line	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer.h	View	1	5 chunks	+47 lines, -5 lines	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer.cc	View		6 chunks	+224 lines, -5 lines	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer_unittest.cc	View		15 chunks	+343 lines, -13 lines	0 comments	Download
M	ui/views/mouse_watcher.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/views/mouse_watcher_view_host.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 9 months ago (2012-03-06 15:40:45 UTC) #2

lgtm

http://codereview.chromium.org/9609016/diff/2001/ash/wm/workspace/multi_windo...
File ash/wm/workspace/multi_window_resize_controller.h (right):

http://codereview.chromium.org/9609016/diff/2001/ash/wm/workspace/multi_windo...
ash/wm/workspace/multi_window_resize_controller.h:42:
~MultiWindowResizeController();
virtual

Expand Messages | Collapse Messages