Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 9609013: Use a hosted app's opener URL and not its origin to locate it. (Closed)

Created:
8 years, 9 months ago by Charlie Reis
Modified:
8 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Mihai Parparita -not on Chrome
Visibility:
Public.

Description

Use a hosted app's opener URL and not its origin to locate it. BUG=113444 TEST=Test with a hosted app that doesn't span an entire origin. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125085

Patch Set 1 #

Patch Set 2 : Also fix content_shell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/mock_content_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/mock_content_browser_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_content_browser_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Drew, can you review the fix? John, can you review for owner's approval? Mihai, CC'ing ...
8 years, 9 months ago (2012-03-06 00:30:24 UTC) #1
Charlie Reis
By the way, I'd love to add a regression test for this in AppBackgroundPageTest.NoJsManifestBackgroundPage, but ...
8 years, 9 months ago (2012-03-06 00:33:43 UTC) #2
Andrew T Wilson (Slow)
LGTM
8 years, 9 months ago (2012-03-06 00:51:28 UTC) #3
jam
8 years, 9 months ago (2012-03-06 01:12:10 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698