Issue 9608015: Fix for a URI issue when opening existing folders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9608015: Fix for a URI issue when opening existing folders. (Closed)

Created:
8 years, 9 months ago by devoncarew

Modified:
8 years, 9 months ago

Reviewers:
pquitslund

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for a URI issue when opening existing folders. Committed: https://code.google.com/p/dart/source/detail?r=5127

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenExternalFolderDialogAction.java	View		3 chunks	+8 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pquitslund

8 years, 9 months ago (2012-03-07 21:15:24 UTC) #2

LGTM.  Thanks!

http://codereview.chromium.org/9608015/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenExternalFolderDialogAction.java
(right):

http://codereview.chromium.org/9608015/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenExternalFolderDialogAction.java:71:
URI location = new File(directory).toURI();
Agh.  That pesky URI.create(..).  Probably my bad... We should really have an
audit for this.

Expand Messages | Collapse Messages