Issue 9605042: Never let the hole escape...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9605042: Never let the hole escape... (Closed)

Created:
8 years, 9 months ago by Sven Panne

Modified:
8 years, 9 months ago

Reviewers:
ulan, fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Never let the hole escape... Committed: https://code.google.com/p/v8/source/detail?r=10951

Patch Set 1 #

Total comments: 3

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -6 lines)			Patch
M	src/objects.h	View	1 chunk	+3 lines, -0 lines	1 comment	Download
M	src/objects.cc	View	3 chunks	+8 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	2 chunks	+4 lines, -4 lines	2 comments	Download
M	test/mjsunit/object-define-property.js	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM http://codereview.chromium.org/9605042/diff/1/src/objects.h File src/objects.h (right): http://codereview.chromium.org/9605042/diff/1/src/objects.h#newcode7948 src/objects.h:7948: Object* SafeGet(AccessorComponent component); Consider marking this function as ...

8 years, 9 months ago (2012-03-07 09:59:34 UTC) #2

fschneider

dbc: http://codereview.chromium.org/9605042/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/9605042/diff/1/src/runtime.cc#newcode10497 src/runtime.cc:10497: details->set(3, AccessorPair::cast(*result_callback_obj)->getter()); Is this call-site safe?

8 years, 9 months ago (2012-03-07 10:32:25 UTC) #3

Sven Panne

8 years, 9 months ago (2012-03-07 10:38:10 UTC) #4

http://codereview.chromium.org/9605042/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/9605042/diff/1/src/runtime.cc#newcode10497
src/runtime.cc:10497: details->set(3,
AccessorPair::cast(*result_callback_obj)->getter());
On 2012/03/07 10:32:25, fschneider wrote:
> Is this call-site safe?

Good point, it's very probably not. New CL approaching... :-P

Expand Messages | Collapse Messages