Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 9605014: Ignore soft heap limit when reserving space. (Closed)

Created:
8 years, 9 months ago by ulan
Modified:
8 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Ignore soft heap limit when reserving space. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=10958

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -13 lines) Patch
M src/heap.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap.cc View 1 2 3 chunks +23 lines, -12 lines 0 comments Download
M src/spaces.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
ulan
Please take a look.
8 years, 9 months ago (2012-03-06 15:58:12 UTC) #1
ulan
Please ignore for now, it's definitely not correct. Will upload the correct version shortly.
8 years, 9 months ago (2012-03-06 16:07:30 UTC) #2
ulan
I uploaded a new patch set, which should be correct this time.
8 years, 9 months ago (2012-03-06 18:45:54 UTC) #3
Michael Starzinger
https://chromiumcodereview.appspot.com/9605014/diff/5001/src/heap.h File src/heap.h (right): https://chromiumcodereview.appspot.com/9605014/diff/5001/src/heap.h#newcode1047 src/heap.h:1047: inline bool AbortIncrementalMarkingAndCollectGarbage( Could we make this a static ...
8 years, 9 months ago (2012-03-07 15:52:42 UTC) #4
ulan
Please take another look. https://chromiumcodereview.appspot.com/9605014/diff/5001/src/heap.h File src/heap.h (right): https://chromiumcodereview.appspot.com/9605014/diff/5001/src/heap.h#newcode1047 src/heap.h:1047: inline bool AbortIncrementalMarkingAndCollectGarbage( On 2012/03/07 ...
8 years, 9 months ago (2012-03-07 16:04:29 UTC) #5
Michael Starzinger
8 years, 9 months ago (2012-03-07 16:06:38 UTC) #6
LGTM.

Powered by Google App Engine
This is Rietveld 408576698