Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 9605006: Consistently order receiver and holder argument in ElementAccessor. (Closed)

Created:
8 years, 9 months ago by danno
Modified:
8 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Consistently order receiver and holder argument in ElementAccessor. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=10943

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -94 lines) Patch
M src/elements.h View 1 2 chunks +23 lines, -12 lines 0 comments Download
M src/elements.cc View 1 16 chunks +80 lines, -71 lines 0 comments Download
M src/objects.cc View 1 6 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
8 years, 9 months ago (2012-03-06 11:01:42 UTC) #1
Jakob Kummerow
LGTM https://chromiumcodereview.appspot.com/9605006/diff/1/src/elements.cc File src/elements.cc (right): https://chromiumcodereview.appspot.com/9605006/diff/1/src/elements.cc#newcode179 src/elements.cc:179: virtual MaybeObject* AddElementsToFixedArray( The Chromium styleguide says that ...
8 years, 9 months ago (2012-03-06 11:57:42 UTC) #2
danno
8 years, 9 months ago (2012-03-06 12:21:54 UTC) #3
Feedback addressed, landing.

http://codereview.chromium.org/9605006/diff/1/src/elements.cc
File src/elements.cc (right):

http://codereview.chromium.org/9605006/diff/1/src/elements.cc#newcode179
src/elements.cc:179: virtual MaybeObject* AddElementsToFixedArray(
On 2012/03/06 11:57:43, Jakob wrote:
> The Chromium styleguide says that in function declarations (as opposed to
> calls), each argument should be on its own line unless all arguments fit on
one
> line.

Done.

http://codereview.chromium.org/9605006/diff/1/src/elements.h
File src/elements.h (right):

http://codereview.chromium.org/9605006/diff/1/src/elements.h#newcode83
src/elements.h:83: // Deleted an element in an object, returning a new elements
backing store.
On 2012/03/06 11:57:43, Jakob wrote:
> s/Deleted/Deletes/

Done.

Powered by Google App Engine
This is Rietveld 408576698