Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 9602003: Extract the last SkColor from ResourceBundle API. (Closed)

Created:
8 years, 9 months ago by tfarina
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Extract the last SkColor from ResourceBundle API. NOTE: This was a TODO for ben@. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124953

Patch Set 1 #

Patch Set 2 : add color_constants.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -17 lines) Patch
M chrome/browser/ui/views/constrained_window_views.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle.h View 2 chunks +0 lines, -6 lines 0 comments Download
ui/base/resource/resource_bundle.cc View 1 chunk +0 lines, -4 lines 0 comments Download
A ui/views/color_constants.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
A ui/views/color_constants.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/window/custom_frame_view.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
8 years, 9 months ago (2012-03-04 20:55:58 UTC) #1
Ben Goodger (Google)
Do you think you can make a color_constants.h file in views instead for these colors ...
8 years, 9 months ago (2012-03-05 15:48:56 UTC) #2
tfarina
On 2012/03/05 15:48:56, Ben Goodger (Google) wrote: > Do you think you can make a ...
8 years, 9 months ago (2012-03-05 16:23:42 UTC) #3
Ben Goodger (Google)
lgtm
8 years, 9 months ago (2012-03-05 16:24:37 UTC) #4
James Cook
8 years, 9 months ago (2012-03-05 17:37:33 UTC) #5
On 2012/03/05 16:24:37, Ben Goodger (Google) wrote:
> lgtm

Thank you guys for getting this done.  The existence of colors in
resource_bundle.h was forever confusing Eclipse.

Powered by Google App Engine
This is Rietveld 408576698