Add OpenGL occlusion query support to pepper.

Add OpenGL occlusion query support to pepper.

Should be full support for opengl es's occlusion query interface. Still only dev interfaces right now.

BUG=88601
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127298

[piman, 2012-03-07 02:22:48]

lgtm

[commit-bot: I haz the power, 2012-03-07 02:28:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/9601020/1

[commit-bot: I haz the power, 2012-03-07 02:28:48]

Presubmit check for 9601020-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
Missing matching PPAPI definition:

***************
  ppapi/api/dev/ppb_opengles2ext_dev.idl
***************

Presubmit checks took 7.2s to calculate.

[jbauman, 2012-03-16 21:42:36]

Adding dmichael for ppapi/ and ppapi/native_client OWNERS review.

[nfullagar, 2012-03-16 21:52:31]

On 2012/03/16 21:42:36, jbauman wrote:
> Adding dmichael for ppapi/ and ppapi/native_client OWNERS review.

Can you update the CL description, as they should do something now :)

[dmichael (off chromium), 2012-03-16 22:15:53]

http://codereview.chromium.org/9601020/diff/9001/ppapi/c/dev/ppb_opengles2ext...
File ppapi/c/dev/ppb_opengles2ext_dev.h (right):

http://codereview.chromium.org/9601020/diff/9001/ppapi/c/dev/ppb_opengles2ext...
ppapi/c/dev/ppb_opengles2ext_dev.h:17: #define
PPB_OPENGLES2_INSTANCEDARRAYS_DEV_INTERFACE
PPB_OPENGLES2_INSTANCEDARRAYS_DEV_INTERFACE_1_0  // NOLINT
Was there something wrong with the previous code? I like it better than using
NOLINT, unless there was a problem (in which case, a comment would be helpful).

http://codereview.chromium.org/9601020/diff/9001/ppapi/native_client/src/shar...
File ppapi/native_client/src/shared/ppapi_proxy/plugin_opengles.cc (right):

http://codereview.chromium.org/9601020/diff/9001/ppapi/native_client/src/shar...
ppapi/native_client/src/shared/ppapi_proxy/plugin_opengles.cc:866: const
PPB_OpenGLES2InstancedArrays_Dev*
PluginGraphics3D::GetOpenGLESInstancedArraysInterface() {  // NOLINT
same comment as before about >80 chars.

http://codereview.chromium.org/9601020/diff/9001/ppapi/shared_impl/ppb_opengl...
File ppapi/shared_impl/ppb_opengles2_shared.cc (right):

http://codereview.chromium.org/9601020/diff/9001/ppapi/shared_impl/ppb_opengl...
ppapi/shared_impl/ppb_opengles2_shared.cc:991: const
PPB_OpenGLES2InstancedArrays_Dev*
PPB_OpenGLES2_Shared::GetInstancedArraysInterface() {  // NOLINT
NOLINT is a big hammer; I think it would be better to put the return type on its
own line, with the rest just below (with no indent).

[jbauman, 2012-03-16 22:19:55]

http://codereview.chromium.org/9601020/diff/9001/ppapi/c/dev/ppb_opengles2ext...
File ppapi/c/dev/ppb_opengles2ext_dev.h (right):

http://codereview.chromium.org/9601020/diff/9001/ppapi/c/dev/ppb_opengles2ext...
ppapi/c/dev/ppb_opengles2ext_dev.h:17: #define
PPB_OPENGLES2_INSTANCEDARRAYS_DEV_INTERFACE
PPB_OPENGLES2_INSTANCEDARRAYS_DEV_INTERFACE_1_0  // NOLINT
On 2012/03/16 22:15:53, dmichael wrote:
> Was there something wrong with the previous code? I like it better than using
> NOLINT, unless there was a problem (in which case, a comment would be
helpful).

This code with the NOLINT is all autogenerated by
gpu/command_buffer/build_gles2_cmd_buffer.py, and the generator changed how it
breaks lines for various reasons.

[dmichael (off chromium), 2012-03-16 22:26:14]

That makes sense, thanks for explaining.

rubber-stamp lgtm