Support for stack traces in catch blocks.

frog/leg/lib/js_helper.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('js_helper');
 
 #import('coreimpl.dart');
 
 #source('date_helper.dart');
 #source('regexp_helper.dart');
@@ skipping 1285 matching lines @@
       }
     }
   } else if (JS('bool', @'$0 instanceof RangeError', ex)) {
     var message = JS('String', @'$0.message', ex);
     if (message.contains('call stack')) {
       return new StackOverflowException();
     }
   }
   return ex;
 }
+
+class StackTrace {

[ahe, 2012/03/06 08:44:22]

This class is hidden from users (because it is defined in this file). Is it
supposed to be part of coreimpl?

[ngeoffray, 2012/03/06 12:12:50]

The StackTrace class/interface is not in core, nor in coreimpl. I belive it
should be in the core library.

+  var stack;
+  StackTrace(this.stack);
+  toString() => stack != null ? stack : '';

[floitsch, 2012/03/06 10:22:32]

Please type toString as returning a String.

[ngeoffray, 2012/03/06 12:12:50]

Done.

+}
+
+getTraceFromException(exception) {

[ahe, 2012/03/06 08:44:22]

Please add a documentation comment that explains where this is called from.

[ngeoffray, 2012/03/06 12:12:50]

Done.

+  return new StackTrace(JS("var", @"$0.stack", exception));

[ahe, 2012/03/06 08:44:22]

Nice. I didn't realize you could use "var" here. But I guess it is obvious.

+}