Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: runtime/vm/flow_graph_builder.h

Issue 9601011: Implement postfix indexed increment. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | runtime/vm/flow_graph_builder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.h
diff --git a/runtime/vm/flow_graph_builder.h b/runtime/vm/flow_graph_builder.h
index 5398dd5d60c6c40f7256324491cee212c8954dbb..b7513d5daf8800d60cfba42d7c84ff8ef0a0bd46 100644
--- a/runtime/vm/flow_graph_builder.h
+++ b/runtime/vm/flow_graph_builder.h
@@ -98,6 +98,10 @@ class EffectGraphVisitor : public AstNodeVisitor {
intptr_t AllocateTempIndex() { return temp_index_++; }
private:
+ // Specify a value as the final result. Does nothing in an effect context
+ // but is normally overridden by subclasses.
+ virtual void ReturnValue(Value* value) { }
+
// Specify a computation as the final result. Adds a Do instruction to
// the graph, but normally overridden in subclasses.
virtual void ReturnComputation(Computation* computation) {
@@ -217,13 +221,13 @@ class TestGraphVisitor : public EffectGraphVisitor {
private:
// Construct and concatenate a Branch instruction to this graph fragment.
// Closes the fragment and sets the output parameters.
- void BranchOnValue(Value* value);
+ void ReturnValue(Value* value);
// Specify a computation as the final result. Adds a Bind instruction to
// the graph and branches on its value.
virtual void ReturnComputation(Computation* computation) {
AddInstruction(new BindInstr(temp_index(), computation));
- BranchOnValue(new TempVal(temp_index()));
+ ReturnValue(new TempVal(temp_index()));
}
// Output parameters.
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | runtime/vm/flow_graph_builder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698