Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: compiler/java/com/google/dart/compiler/ast/DartClass.java

Issue 9600049: Use NodeList where possible. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/ast/DartClass.java
diff --git a/compiler/java/com/google/dart/compiler/ast/DartClass.java b/compiler/java/com/google/dart/compiler/ast/DartClass.java
index fa21514a87fe844b26fc3e15fa6e14546e6506af..36d7c5cee2cb65ad26920e4fcdc8975c8fe5351f 100644
--- a/compiler/java/com/google/dart/compiler/ast/DartClass.java
+++ b/compiler/java/com/google/dart/compiler/ast/DartClass.java
@@ -19,9 +19,9 @@ public class DartClass extends DartDeclaration<DartIdentifier> implements HasSym
private DartTypeNode superclass;
- private final List<DartNode> members;
- private final List<DartTypeParameter> typeParameters;
- private final List<DartTypeNode> interfaces;
+ private final NodeList<DartNode> members = NodeList.create(this);
+ private final NodeList<DartTypeParameter> typeParameters = NodeList.create(this);
+ private final NodeList<DartTypeNode> interfaces = NodeList.create(this);
private boolean isInterface;
private DartParameterizedTypeNode defaultClass;
@@ -64,9 +64,9 @@ public class DartClass extends DartDeclaration<DartIdentifier> implements HasSym
super(name);
this.nativeName = nativeName;
this.superclass = becomeParentOf(superclass);
- this.members = becomeParentOf(members);
- this.typeParameters = becomeParentOf(typeParameters);
- this.interfaces = becomeParentOf(interfaces);
+ this.members.addAll(members);
+ this.typeParameters.addAll(typeParameters);
+ this.interfaces.addAll(interfaces);
this.defaultClass = becomeParentOf(defaultClass);
this.isInterface = isInterface;
this.modifiers = modifiers;
@@ -170,15 +170,15 @@ public class DartClass extends DartDeclaration<DartIdentifier> implements HasSym
@Override
public void visitChildren(ASTVisitor<?> visitor) {
- visitor.visit(typeParameters);
+ typeParameters.accept(visitor);
if (superclass != null) {
superclass.accept(visitor);
}
- visitor.visit(interfaces);
+ interfaces.accept(visitor);
if (defaultClass != null) {
defaultClass.accept(visitor);
}
- visitor.visit(members);
+ members.accept(visitor);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698