compiler/java/com/google/dart/compiler/ast/LibraryUnit.java - Issue 9600049: Use NodeList where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/ast/LibraryUnit.java

Issue 9600049: Use NodeList where possible. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« compiler/java/com/google/dart/compiler/ast/DartTypeNode.java ('K') | « compiler/java/com/google/dart/compiler/ast/DartVariableStatement.java ('k') | compiler/java/com/google/dart/compiler/ast/NodeList.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/ast/LibraryUnit.java

diff --git a/compiler/java/com/google/dart/compiler/ast/LibraryUnit.java b/compiler/java/com/google/dart/compiler/ast/LibraryUnit.java

index 195f494141feb31b77f8e37d363db1de79cfb5b6..19dfa925de1b69ee7202bcfbec98316ca4862ecf 100644

--- a/compiler/java/com/google/dart/compiler/ast/LibraryUnit.java

+++ b/compiler/java/com/google/dart/compiler/ast/LibraryUnit.java

@@ -4,6 +4,8 @@

package com.google.dart.compiler.ast;

+import com.google.common.collect.Lists;

+import com.google.common.collect.Maps;

import com.google.dart.compiler.DartCompiler;

import com.google.dart.compiler.DartCompilerContext;

import com.google.dart.compiler.DartSource;

@@ -15,10 +17,9 @@ import com.google.dart.compiler.resolver.LibraryElement;

import java.io.IOException;

import java.io.Reader;

import java.io.Writer;

-import java.util.ArrayList;

import java.util.Collection;

-import java.util.HashMap;

import java.util.HashSet;

+import java.util.List;

import java.util.Map;

import java.util.Set;

import java.util.concurrent.ConcurrentSkipListMap;

@@ -29,14 +30,14 @@ import java.util.concurrent.ConcurrentSkipListMap;

public class LibraryUnit {

private final LibrarySource libSource;

private final LibraryNode selfSourcePath;

- private final Collection<LibraryNode> importPaths = new ArrayList<LibraryNode>();

- private final Collection<LibraryNode> sourcePaths = new ArrayList<LibraryNode>();

- private final Collection<LibraryNode> resourcePaths = new ArrayList<LibraryNode>();

- private final Collection<LibraryNode> nativePaths = new ArrayList<LibraryNode>();

+ private final List<LibraryNode> importPaths = Lists.newArrayList();

+ private final List<LibraryNode> sourcePaths = Lists.newArrayList();

+ private final List<LibraryNode> resourcePaths = Lists.newArrayList();

+ private final List<LibraryNode> nativePaths = Lists.newArrayList();

private final Map<String, DartUnit> units = new ConcurrentSkipListMap<String, DartUnit>();

- private final Collection<LibraryUnit> imports = new ArrayList<LibraryUnit>();

- private final Map<LibraryUnit, String> prefixes = new HashMap<LibraryUnit, String>();

+ private final Collection<LibraryUnit> imports = Lists.newArrayList();

+ private final Map<LibraryUnit, String> prefixes = Maps.newHashMap();

private final LibraryElement element;