Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: compiler/java/com/google/dart/compiler/ast/DartParameterizedTypeNode.java

Issue 9600049: Use NodeList where possible. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/ast/DartParameterizedTypeNode.java
diff --git a/compiler/java/com/google/dart/compiler/ast/DartParameterizedTypeNode.java b/compiler/java/com/google/dart/compiler/ast/DartParameterizedTypeNode.java
index b8f4776181649554604db2b4d425fbd6a3294ad5..610e740f7c20499f20625f40b3e55eaefbd6b1e0 100644
--- a/compiler/java/com/google/dart/compiler/ast/DartParameterizedTypeNode.java
+++ b/compiler/java/com/google/dart/compiler/ast/DartParameterizedTypeNode.java
@@ -6,17 +6,16 @@ package com.google.dart.compiler.ast;
import com.google.dart.compiler.type.Type;
-import java.util.Collections;
import java.util.List;
public class DartParameterizedTypeNode extends DartExpression {
private DartExpression expression;
- private List<DartTypeParameter> typeParameters;
+ private final NodeList<DartTypeParameter> typeParameters = NodeList.create(this);
private Type type;
public DartParameterizedTypeNode(DartExpression expression, List<DartTypeParameter> typeParameters) {
setExpression(expression);
- setTypeParameters(typeParameters);
+ this.typeParameters.addAll(typeParameters);
}
@Override
@@ -46,16 +45,9 @@ public class DartParameterizedTypeNode extends DartExpression {
this.type = type;
}
- public void setTypeParameters(List<DartTypeParameter> typeParameters) {
- if (typeParameters == null) {
- typeParameters = Collections.emptyList();
- }
- this.typeParameters = becomeParentOf(typeParameters);
- }
-
@Override
public void visitChildren(ASTVisitor<?> visitor) {
getExpression().accept(visitor);
- visitor.visit(getTypeParameters());
+ typeParameters.accept(visitor);
}
}

Powered by Google App Engine
This is Rietveld 408576698