Add Password Autofill Manager to New Autofill

chrome/common/autofill_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, hence no include guard.
 
 #include <string>
 
 #include "base/time.h"
 #include "content/public/common/webkit_param_traits.h"
@@ skipping 64 matching lines @@
                     std::vector<string16> /* icons */,
                     std::vector<int> /* unique_ids */)
 
 // Reply to the AutofillHostMsg_FillAutofillFormData message with the
 // Autofill form data.
 IPC_MESSAGE_ROUTED2(AutofillMsg_FormDataFilled,
                     int /* id of the request message */,
                     webkit::forms::FormData /* form data */)
 
 // Fill a password form and prepare field autocomplete for multiple
-// matching logins.
-IPC_MESSAGE_ROUTED1(AutofillMsg_FillPasswordForm,
-                    webkit::forms::PasswordFormFillData)
+// matching logins. Lets the renderer know if it should disable the popup
+// because the browser process will own the popup UI.
+IPC_MESSAGE_ROUTED2(AutofillMsg_FillPasswordForm,
+                    webkit::forms::PasswordFormFillData, /* the fill form data*/
+                    bool /* disable popup */ )
 
 // Send the heuristic and server field type predictions to the renderer.
 IPC_MESSAGE_ROUTED1(
     AutofillMsg_FieldTypePredictionsAvailable,
     std::vector<webkit::forms::FormDataPredictions> /* forms */)
 
 // Select an Autofill item when using an external delegate.
 IPC_MESSAGE_ROUTED1(AutofillMsg_SelectAutofillSuggestionAtIndex,
                     int /* listIndex */)
 
@@ skipping 11 matching lines @@
 
 // Sets the currently selected nodes value.
 IPC_MESSAGE_ROUTED1(AutofillMsg_SetNodeText,
                     string16)
 
 // Tells the renderer to populate the correct password fields with this
 // generated password.
 IPC_MESSAGE_ROUTED1(AutofillMsg_GeneratedPasswordAccepted,
                     string16 /* generated_password */)
 
+// Tells the renderer that the password field has accept the suggestion.
+IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptPasswordAutofillSuggestion,
+                    string16)

[Ilya Sherman, 2012/04/02 22:07:29]

nit: Please add a quick comment to describe the string16 parameter

[csharp, 2012/04/03 12:25:55]

Done.

+
 // Autofill messages sent from the renderer to the browser.
 
 // Notification that forms have been seen that are candidates for
 // filling/submitting by the AutofillManager.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_FormsSeen,
                     std::vector<webkit::forms::FormData> /* forms */,
                     base::TimeTicks /* timestamp */)
 
 // Notification that password forms have been seen that are candidates for
 // filling/submitting by the password manager.
@@ skipping 50 matching lines @@
                     string16 /* value */)
 
 // Instructs the browser to show the Autofill dialog.
 IPC_MESSAGE_ROUTED0(AutofillHostMsg_ShowAutofillDialog)
 
 // Send when a text field is done editing.
 IPC_MESSAGE_ROUTED0(AutofillHostMsg_DidEndTextFieldEditing)
 
 // Instructs the browser to hide the Autofill popup.
 IPC_MESSAGE_ROUTED0(AutofillHostMsg_HideAutofillPopup)
 

[Ilya Sherman, 2012/04/02 22:07:29]

nit: No need for this extra blank line (line 195)

[csharp, 2012/04/03 12:25:55]

Done.

+
 // Instructs the browser to show the password generation bubble at the
 // specified location. This location should be specified in the renderers
 // coordinate system.
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_ShowPasswordGenerationPopup,
                     gfx::Rect /* source location */)
+
+// Instruct the browser that a password mapping has been found for a field.
+IPC_MESSAGE_ROUTED2(AutofillHostMsg_AddPasswordFormMapping,
+                    webkit::forms::FormField, /* the user name field */
+                    webkit::forms::PasswordFormFillData /*the form fill data */)

[Ilya Sherman, 2012/04/02 22:07:29]

nit: There should be a space between "/*" and "the" in the comment.  Also, "form
fill data" strikes me as really vague -- is there a concise way to describe what
that data actually consists of?  (If not, it's fine to leave the vague comment
-- concision is probably more important here.)

[csharp, 2012/04/03 12:25:55]

Changed the text to "password pairing", still a bit vague but I think it gives a
better ideas of what it represents.

+
+// Instruct the browser to show a popup with the following suggestions from the
+// password manager.
+IPC_MESSAGE_ROUTED3(AutofillHostMsg_ShowPasswordSuggestions,
+                    webkit::forms::FormField /* the form field */,
+                    gfx::Rect /* input field bounds, window-relative */,
+                    std::vector<string16> /* suggestions */)