Add Password Autofill Manager to New Autofill

webkit/forms/form_field.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FORMS_FORM_FIELD_H_
 #define WEBKIT_FORMS_FORM_FIELD_H_
 
 #include <vector>
 
 #include "base/string16.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFormControlElement.h"
 #include "webkit/forms/webkit_forms_export.h"
 
 namespace webkit {
 namespace forms {
 
 // Stores information about a field in a form.
 struct WEBKIT_FORMS_EXPORT FormField {
   FormField();
   virtual ~FormField();
 
   // Equality tests for identity which does not include |value| or
   // |is_autofilled|.
   // TODO(dhollowa): These operators need to be revised when we implement field
   // ids.
   bool operator==(const FormField& field) const;
   bool operator!=(const FormField& field) const;
+  bool operator<(const FormField& field) const;

[csharp, 2012/03/06 16:09:23]

Not sure how best to deal with this. Using the map in the manager needs some
sorting ability so adding a comparison function would be the right move, but I'm
not 100% sure I need the map (maybe just a vector instead). Thoughts?

We need some sorting to be able to use the map in the password autofill manager,
should I change this into a comparison function or try and use something other
than a map in the manager?

[Ilya Sherman, 2012/03/06 20:32:44]

This seems fine, but please add a comment that this operator is exposed for the
sake of using an STL map.

[csharp, 2012/03/07 15:49:16]

Done.

 
   string16 label;
   string16 name;
   string16 value;
   string16 form_control_type;
   string16 autocomplete_type;
   size_t max_length;
   bool is_autofilled;
   bool is_focusable;
   bool should_autocomplete;
@@ skipping 18 matching lines @@
     EXPECT_EQ(expected.label, actual.label); \
     EXPECT_EQ(expected.name, actual.name); \
     EXPECT_EQ(expected.value, actual.value); \
     EXPECT_EQ(expected.form_control_type, actual.form_control_type); \
     EXPECT_EQ(expected.autocomplete_type, actual.autocomplete_type); \
     EXPECT_EQ(expected.max_length, actual.max_length); \
     EXPECT_EQ(expected.is_autofilled, actual.is_autofilled); \
   } while (0)
 
 #endif  // WEBKIT_FORMS_FORM_FIELD_H_