Add Password Autofill Manager to New Autofill

chrome/browser/autofill/password_autofill_manager.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_AUTOFILL_PASSWORD_AUTOFILL_MANAGER_H_
+#define CHROME_BROWSER_AUTOFILL_PASSWORD_AUTOFILL_MANAGER_H_
+#pragma once
+
+// This file was contains some repeated code from
+// chrome/renderer/autofill/password_autofill_manager because as we move to the
+// new Autofill UI we needs these functions in both the browser and renderer.
+// Once the move is completed the repeated code in the renderer half should be
+// removed.
+// http://crbug.com/51644
+
+#include <map>
+
+#include "webkit/forms/password_form_dom_manager.h"
+
+namespace content {
+class RenderViewHost;
+}  // namespace content
+
+// This class is responsible for filling password forms.
+class PasswordAutofillManager {
+ public:
+  explicit PasswordAutofillManager(content::RenderViewHost* render_view_host);
+  virtual ~PasswordAutofillManager();
+
+  // If this return true, it indicates the event would be consumed by the
+  // password manager in the renderer, so we shouldn't attempt to handle the
+  // key down, but instead pass it to the renderer.
+  bool WouldHandleKeyDown(const webkit::forms::FormField& field);
+
+  // Fills the password associated with user name |value|. Returns true if the
+  // username and password fields were filled, false otherwise.
+  bool DidAcceptAutofillSuggestion(const webkit::forms::FormField& field,
+                                   const string16& value);
+
+  // A no-op.  No filling happens for selection.  But this method returns
+  // true when |node| is fillable by password Autofill.
+  bool DidSelectAutofillSuggestion(const webkit::forms::FormField& field);
+
+  // A no-op.  Password forms are not previewed, so they do not need to be
+  // cleared when the selection changes.  However, this method returns
+  // true when |node| is fillable by password Autofill.
+  bool DidClearAutofillSelection(const webkit::forms::FormField& field);
+
+  // Invoked when a password form is filled.
+  void FillPasswordForm(const webkit::forms::FormField& username_element,
+                        const webkit::forms::PasswordFormFillData& form_data,
+                        long long frame_id);
+
+  // Invoked when the passed frame is closing.  Gives us a chance to clear any
+  // reference we may have to elements in that frame.
+  void FrameClosing(long long frame_id);

[Ilya Sherman, 2012/03/08 23:22:14]

I think it should be safe, and much simpler, to just reset the
login_to_password_info_ map as part of AutofillManager::Reset()

[csharp, 2012/03/09 16:20:19]

k, I'll make that change. I'll also add a comment in FrameClosing mentioning
this choice in case it starts causing trouble later.

+
+ private:
+  struct PasswordInfo {
+    long long frame_id;
+    webkit::forms::PasswordFormFillData fill_data;
+  };
+  typedef std::map<webkit::forms::FormField, PasswordInfo>
+      LoginToPasswordInfoMap;
+
+  bool WillFillUserNameAndPassword(
+      const webkit::forms::FormField& username_element,
+      const webkit::forms::PasswordFormFillData& fill_data);
+
+  // Finds login information for a |node| that was previously filled.
+  bool FindLoginInfo(const webkit::forms::FormField& field,
+                     webkit::forms::FormField* found_input,
+                     PasswordInfo* found_password);
+
+  // The logins we have filled so far with their associated info.
+  LoginToPasswordInfoMap login_to_password_info_;
+
+  content::RenderViewHost* render_view_host_;  // Weak reference.
+
+  DISALLOW_COPY_AND_ASSIGN(PasswordAutofillManager);
+};
+
+#endif  // CHROME_BROWSER_AUTOFILL_PASSWORD_AUTOFILL_MANAGER_H_