client/html/src/shared_FactoryProviders.dart - Issue 9600035: Enable new dart:html wrapperless frog bindings and wrapper dartium bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/html/src/shared_FactoryProviders.dart

Issue 9600035: Enable new dart:html wrapperless frog bindings and wrapper dartium bindings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Handle all code review comments Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/html/src/shared_FactoryProviders.dart

diff --git a/client/html/src/shared_FactoryProviders.dart b/client/html/src/shared_FactoryProviders.dart

index d2fdcbebd48318df3ba94aa681ad701600ff1e92..b12c663a2e1045cfcb32f86eeba85a1f5826e29e 100644

--- a/client/html/src/shared_FactoryProviders.dart

+++ b/client/html/src/shared_FactoryProviders.dart

@@ -4,7 +4,7 @@

class _TextFactoryProvider {

- factory Text(data) => document._createTextNode(data);

+ factory Text(String data) => document._createTextNode(data);

}

class _EventFactoryProvider {

@@ -49,7 +49,6 @@ class _ElementFactoryProvider {

'head' : 'html',

'caption' : 'table',

'td': 'tr',

- 'tbody': 'table',

'colgroup': 'table',

'col' : 'colgroup',

'tr' : 'tbody',

« no previous file with comments | « client/html/htmlimpl.dart ('k') | client/testing/unittest/dom_for_unittest.dart » ('j') | no next file with comments »