Clean up temporary directories in buildbot script.

frog/scripts/buildbot_annotated_steps.py

 #!/usr/bin/python
 
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Dart frog buildbot steps
 
 Runs tests for the frog compiler (running on the vm or the self-hosting version)
 """
@@ skipping 142 matching lines @@
       if system.startswith('win') and browser == 'ie':
         # There should not be more than one InternetExplorerDriver instance
         # running at a time. For details, see
         # http://code.google.com/p/selenium/wiki/InternetExplorerDriver.
         additional_flags += ['-j1']
       TestStep(browser, mode, system, 'webdriver', tests,
           flags + additional_flags)
 
   return 0
 
+def CleanUpTemporaryFiles(system, browser):
+  """For some browser (selenium) tests, the browser creates a temporary profile 
+  on each browser session start. On Windows, generally these files are 
+  automatically deleted when all python processes complete. However, since our 
+  buildbot slave script also runs on python, we never get the opportunity to 
+  clear out the temp files, so we do so explicitly here. Our batch browser
+  testing will make this problem occur much less frequently, but will still
+  happen eventually unless we do this.
+
+  This problem also occurs with batch tests in Firefox. For some reason selenium
+  automatically deletes the temporary profiles for Firefox for one browser,
+  but not multiple ones when we have many open batch tasks running. This
+  behavior has not been able to be reproduced outside of the buildbots.

[Siggi Cherem (dart-lang), 2012/03/05 21:22:25]

has not been able to be reproduced
=>
has not been reproduced

[Emily Fortuna, 2012/03/05 21:50:18]

Done.

+  
+  Args:
+     - system: either 'linux', 'mac', or 'win7'
+     - browser: one of the browsers, see GetBuildInfo
+  """
+  if system == 'win7':
+    subprocess.Popen(['rmdir', '/S', '/Q',
+      'C:\\Users\\chrome-bot\\AppData\\Local\\Temp'], shell=True)
+  elif browser == 'ff':
+    # Note: the buildbots run as root, so we can do this without requiring a
+    # password. The command won't actually work on regular machines without
+    # root permissions.
+    p = subprocess.Popen('rm -rf /tmp/*', shell=True)

[Siggi Cherem (dart-lang), 2012/03/05 21:22:25]

This might be overly agressive - there might be temporary files needed there?
(we use to create our own temps in /tmp/ in test.py). Is there a prefix for the
firefox files that we can use here?

[Emily Fortuna, 2012/03/05 21:50:18]

The firefox profiles all seem to have a particular format (a bunch of letters,
and maybe numbers), but no defining prefix. This runs after test.py is complete
(at the very end), so test.py shouldn't be relying on any temporary files lying
around...? Also if a file is still being used, the OS won't let you delete it
(tested on all OSs).

On 2012/03/05 21:22:25, sigmund wrote:

+    p = subprocess.Popen('rm -rf /var/tmp/*', shell=True)
 
 def main():
   print 'main'
   if len(sys.argv) == 0:
     print 'Script pathname not known, giving up.'
     return 1
 
   arch, mode, system, browser = GetBuildInfo()
   print "arch: %s, mode: %s, system: %s, browser %s" % (arch, mode, system,
       browser)
   if arch is None:
     return 1
 
   status = BuildFrog(arch, mode, system)
   if status != 0:
     print '@@@STEP_FAILURE@@@'
     return status
 
   if arch != 'frogium':
     status = TestFrog(arch, mode, system, browser, [])
     if status != 0:
       print '@@@STEP_FAILURE@@@'
       return status
 
   status = TestFrog(arch, mode, system, browser, ['--checked'])
   if status != 0:
     print '@@@STEP_FAILURE@@@'
 
+  if arch == 'frogium':

[Siggi Cherem (dart-lang), 2012/03/05 21:22:25]

arch == webdriver?

[Emily Fortuna, 2012/03/05 21:50:18]

See line 51. Webdriver is not the *architecture*, it is just the type of test to
run. 

On 2012/03/05 21:22:25, sigmund wrote:

+    CleanUpTemporaryFiles(system, browser)
   return status
 
 
 if __name__ == '__main__':
   sys.exit(main())