Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: webkit/blob/blob_url_request_job.h

Issue 9600032: Cleanup: rename some methods in BlobURLRequestJob for better readability (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/blob/blob_url_request_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/blob/blob_url_request_job.h
diff --git a/webkit/blob/blob_url_request_job.h b/webkit/blob/blob_url_request_job.h
index 26067fd12e5fe5ef9cc30f0f1eba8764c0dc2c35..747f7734ff463022663b18595226dac60ae9ce5c 100644
--- a/webkit/blob/blob_url_request_job.h
+++ b/webkit/blob/blob_url_request_job.h
@@ -60,18 +60,18 @@ class BLOB_EXPORT BlobURLRequestJob : public net::URLRequestJob {
bool ReadItem();
void AdvanceItem();
void AdvanceBytesRead(int result);
- bool ReadBytes(const BlobData::Item& item);
- bool DispatchReadFile(const BlobData::Item& item);
+ bool ReadBytesItem(const BlobData::Item& item);
+ bool ReadFileItem(const BlobData::Item& item);
- void DidOpen(base::PlatformFileError rv,
- base::PassPlatformFile file,
- bool created);
- bool ReadFile();
- void DidRead(int result);
- void CloseStream();
+ void DidOpenForReadFile(base::PlatformFileError rv,
michaeln 2012/03/05 22:56:41 maybe DidOpenFileForRead or just DidOpenFile?
kinuko 2012/03/06 00:01:57 Sounds better, will rename to DidOpenFile.
+ base::PassPlatformFile file,
+ bool created);
+ bool ReadFileStream();
+ void DidReadFileStream(int result);
+ void CloseFileStream();
int ComputeBytesToRead() const;
- int ReadCompleted();
+ int BytesReadCompleted();
void NotifySuccess();
void NotifyFailure(int);
« no previous file with comments | « no previous file | webkit/blob/blob_url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698