Issue 9600032: Cleanup: rename some methods in BlobURLRequestJob for better readability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9600032: Cleanup: rename some methods in BlobURLRequestJob for better readability (Closed)

Created:
8 years, 9 months ago by kinuko

Modified:
8 years, 9 months ago

Reviewers:
michaeln

CC:
chromium-reviews, jianli

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup: rename some methods in BlobURLRequestJob for better readability - ReadBytes -> ReadBytesItem - DispatchReadFile -> ReadFileItem - DidOpen -> DidOpenFile - ReadFile -> ReadFileStream - DidRead -> DidReadFileStream - CloseStream -> CloseFileStream - ReadCompleted -> BytesReadCompleted BUG=114999 TEST=existing tests should pass Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125097

Patch Set 1 #

Total comments: 2

Patch Set 2 : DidOpenFile #

Patch Set 3 : rebase #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -30 lines)			Patch
	M	webkit/blob/blob_url_request_job.h	View	1	1 chunk	+9 lines, -9 lines	0 comments	Download
	M	webkit/blob/blob_url_request_job.cc	View	1	13 chunks	+21 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

michaeln

lgtm https://chromiumcodereview.appspot.com/9600032/diff/1/webkit/blob/blob_url_request_job.h File webkit/blob/blob_url_request_job.h (right): https://chromiumcodereview.appspot.com/9600032/diff/1/webkit/blob/blob_url_request_job.h#newcode66 webkit/blob/blob_url_request_job.h:66: void DidOpenForReadFile(base::PlatformFileError rv, maybe DidOpenFileForRead or just DidOpenFile?

8 years, 9 months ago (2012-03-05 22:56:41 UTC) #2

kinuko

8 years, 9 months ago (2012-03-06 00:01:57 UTC) #3

https://chromiumcodereview.appspot.com/9600032/diff/1/webkit/blob/blob_url_re...
File webkit/blob/blob_url_request_job.h (right):

https://chromiumcodereview.appspot.com/9600032/diff/1/webkit/blob/blob_url_re...
webkit/blob/blob_url_request_job.h:66: void
DidOpenForReadFile(base::PlatformFileError rv,
On 2012/03/05 22:56:41, michaeln wrote:
> maybe DidOpenFileForRead or just DidOpenFile?

Sounds better, will rename to DidOpenFile.

Expand Messages | Collapse Messages