Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(32)

Issue 9600027: Merge 106476 - Source/WebCore: preventDefault() in a mousedown in a subframe should not (Closed)

Created:
8 years, 6 months ago by Nate Chapin
Modified:
8 years, 6 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Merge 106476 - Source/WebCore: preventDefault() in a mousedown in a subframe should not prevent the scrollbar from handling mouse movements if the cursor leaves the subframe. https://bugs.webkit.org/show_bug.cgi?id=73097 Reviewed by Darin Adler. Test: fast/events/scroll-div-with-prevent-default-in-subframe.html * page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=73097. Test adapted from repro case provided by zacklloyd@google.com. Reviewed by Darin Adler. * fast/events/resources/subframe-with-scrollable-div.html: Added. * fast/events/scroll-div-with-prevent-default-in-subframe-expected.txt: Added. * fast/events/scroll-div-with-prevent-default-in-subframe.html: Added. TBR=japhet@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=109763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, --2 lines) Patch
A + LayoutTests/fast/events/resources/subframe-with-scrollable-div.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/events/scroll-div-with-prevent-default-in-subframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/events/scroll-div-with-prevent-default-in-subframe-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/page/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Nate Chapin
8 years, 6 months ago (2012-03-05 18:22:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698