Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6840)

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

Issue 9600024: Disabling ClientSideDetectionHostTest.OnPhishingDetectionDoneNotPhishing on Linux. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: noop Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
diff --git a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
index 55dc35f2df0d56555d1b47db662c7da1eb10d222..d9826fd5d2a5e61d4bf8b9e5d7e1c3bb354a179d 100644
--- a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
+++ b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
@@ -323,7 +323,17 @@ TEST_F(ClientSideDetectionHostTest, OnPhishingDetectionDoneInvalidVerdict) {
EXPECT_TRUE(Mock::VerifyAndClear(mock_extractor));
}
-TEST_F(ClientSideDetectionHostTest, OnPhishingDetectionDoneNotPhishing) {
+#if defined(OS_LINUX)
+// Crashes on linux_chromeos. http://crbug.com/115979
+#define MAYBE_OnPhishingDetectionDoneNotPhishing \
+ DISABLED_OnPhishingDetectionDoneNotPhishing
+#else
+#define MAYBE_OnPhishingDetectionDoneNotPhishing \
+ OnPhishingDetectionDoneNotPhishing
+#endif
+
+TEST_F(ClientSideDetectionHostTest,
+ MAYBE_OnPhishingDetectionDoneNotPhishing) {
// Case 1: client thinks the page is phishing. The server does not agree.
// No interstitial is shown.
MockBrowserFeatureExtractor* mock_extractor = new MockBrowserFeatureExtractor(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698