Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 9600020: Ensure that inner pseudo-chunks are correctly initialized in FreeQueuedChunks. (Closed)

Created:
8 years, 9 months ago by Vyacheslav Egorov (Chromium)
Modified:
8 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Ensure that inner pseudo-chunks are correctly initialized in FreeQueuedChunks. Fields introduced with guarding code space pages (area_start_, area_end_) were not correctly handled which lead to errors in StoreBuffer filtering. R=mstarzinger@chromium.org TEST=mozilla/data/js1_5/GC/regress-203278-2.js Committed: https://code.google.com/p/v8/source/detail?r=10927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M src/heap.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/spaces.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
8 years, 9 months ago (2012-03-05 15:40:09 UTC) #1
Michael Starzinger
8 years, 9 months ago (2012-03-05 16:12:00 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698