Issue 9600016: Generate more compact code in regexp assembler with near jumps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9600016: Generate more compact code in regexp assembler with near jumps. (Closed)

Created:
8 years, 9 months ago by Yang

Modified:
8 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Generate more compact code in regexp assembler with near jumps. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10924

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -23 lines)			Patch
	M	src/ia32/regexp-macro-assembler-ia32.cc	View		10 chunks	+14 lines, -14 lines	1 comment	Download
	M	src/x64/regexp-macro-assembler-x64.cc	View		8 chunks	+9 lines, -9 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 9 months ago (2012-03-05 14:35:31 UTC) #2

LGTM.

http://codereview.chromium.org/9600016/diff/1/src/ia32/regexp-macro-assembler...
File src/ia32/regexp-macro-assembler-ia32.cc (right):

http://codereview.chromium.org/9600016/diff/1/src/ia32/regexp-macro-assembler...
src/ia32/regexp-macro-assembler-ia32.cc:1: // Copyright 2011 the V8 project
authors. All rights reserved.
nit: 2012

http://codereview.chromium.org/9600016/diff/1/src/x64/regexp-macro-assembler-...
File src/x64/regexp-macro-assembler-x64.cc (right):

http://codereview.chromium.org/9600016/diff/1/src/x64/regexp-macro-assembler-...
src/x64/regexp-macro-assembler-x64.cc:1: // Copyright 2011 the V8 project
authors. All rights reserved.
nit: 2012

Expand Messages | Collapse Messages