Use an enum for indicating the component of an AccessorPair instead of a boolean flag.

Use an enum for indicating the component of an AccessorPair instead of a boolean flag.

In addition, this CL introduces a tiny new helper, which will come in handy later,
plus some minor cleanup.

Committed: https://code.google.com/p/v8/source/detail?r=10918

[Michael Starzinger, 2012-03-05 11:56:30]

LGTM.

https://chromiumcodereview.appspot.com/9600013/diff/1/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/9600013/diff/1/src/objects.h#newcode7937
src/objects.h:7937: Object* get(AccessorComponent component) {
If you plan on extending AccessorComponent later (e.g. by ACCESSOR_NONE), it
might be good to have the following assertion in these two functions. Your call.

ASSERT(component == ACCESSOR_GETTER || component == ACCESSOR_SETTER);

[Sven Panne, 2012-03-05 12:08:51]

http://codereview.chromium.org/9600013/diff/1/src/objects.h
File src/objects.h (right):

http://codereview.chromium.org/9600013/diff/1/src/objects.h#newcode7937
src/objects.h:7937: Object* get(AccessorComponent component) {
On 2012/03/05 11:56:30, Michael Starzinger wrote:
> If you plan on extending AccessorComponent later (e.g. by ACCESSOR_NONE), it
> might be good to have the following assertion in these two functions. Your
call.
> 
> ASSERT(component == ACCESSOR_GETTER || component == ACCESSOR_SETTER);

Given C++'s lovely implicit conversions, I think the ASSERT here and in set
below are a good idea. Done.