Issue 9600006: Aura: Remove overlapping window mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9600006: Aura: Remove overlapping window mode (Closed)

Created:
8 years, 9 months ago by James Cook

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Aura: Remove overlapping window mode We're going with "managed" window mode. Oshima made it the default last week and updated the tests, so this just removes the unused mode. I also removed Shell::set_compact_window_mode_for_test() in favor of using ShellDelegate::GetOverrideWindowMode() for the one test that needs compact mode. BUG=116614 TEST=aura_shell_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124961

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -84 lines)			Patch
M	ash/ash_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/ash_switches.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ash/shell.h	View	4 chunks	+4 lines, -14 lines	0 comments	Download
M	ash/shell.cc	View	6 chunks	+7 lines, -23 lines	0 comments	Download
M	ash/shell_unittest.cc	View	3 chunks	+9 lines, -23 lines	0 comments	Download
M	ash/test/ash_test_base.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/test/test_shell_delegate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/toplevel_layout_manager.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ash/wm/workspace/workspace_event_filter_unittest.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	ash/wm/workspace/workspace_manager_unittest.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

James Cook

Ben, PTAL. This gets us down to two window modes. I elected to keep your ...

8 years, 9 months ago (2012-03-04 20:19:12 UTC) #1

lgtm

Expand Messages | Collapse Messages