Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: dart/frog/leg/ssa/optimize.dart

Issue 9599026: Generate code for some switch statements. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Update status files and work around a failed assertion Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/frog/leg/ssa/optimize.dart
diff --git a/dart/frog/leg/ssa/optimize.dart b/dart/frog/leg/ssa/optimize.dart
index 7fdf1b0dcabaaea1b11b0a6aa0b9d002301519ec..634111625adf00689c8f9addfb1e6172a1b03d65 100644
--- a/dart/frog/leg/ssa/optimize.dart
+++ b/dart/frog/leg/ssa/optimize.dart
@@ -326,7 +326,7 @@ class SsaDeadPhiEliminator implements OptimizationPhase {
HPhi next = null;
while (current != null) {
next = current.next;
- if (!livePhis.contains(current)) {
+ if (!livePhis.contains(current) && current.usedBy.isEmpty()) {
ahe 2012/03/05 22:58:35 Not sure about this.
Lasse Reichstein Nielsen 2012/03/06 08:57:14 If it isn't empty, we will hit an assert in remove
ahe 2012/03/06 09:16:50 I don't understand what you're talking about. I do
block.removePhi(current);
}
current = next;

Powered by Google App Engine
This is Rietveld 408576698