In CrMallocErrorBreak, do not kill the process if errno is ENOMEM.

base/process_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #define _CRT_SECURE_NO_WARNINGS
 
 #include <limits>
 
 #include "base/command_line.h"
 #include "base/eintr_wrapper.h"
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/test/multiprocess_test.h"
 #include "base/test/test_timeouts.h"
 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
 #include "base/threading/platform_thread.h"
 #include "base/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/multiprocess_func_list.h"
 
 #if defined(OS_LINUX)
-#include <errno.h>
 #include <malloc.h>
 #include <glib.h>
 #include <sched.h>
 #endif
 #if defined(OS_POSIX)
+#include <errno.h>
 #include <dlfcn.h>
 #include <fcntl.h>
 #include <signal.h>
 #include <sys/resource.h>
 #include <sys/socket.h>
 #include <sys/wait.h>
 #endif
 #if defined(OS_WIN)
 #include <windows.h>
 #endif
 #if defined(OS_MACOSX)
+#include <cmath>
 #include <malloc/malloc.h>
 #include "base/process_util_unittest_mac.h"
 #endif
 
 namespace {
 
 #if defined(OS_WIN)
 const wchar_t kProcessName[] = L"base_unittests.exe";
 #else
 const wchar_t kProcessName[] = L"base_unittests";
@@ skipping 395 matching lines @@
 
 #endif  // defined(OS_WIN)
 
 #if defined(OS_MACOSX)
 
 TEST_F(ProcessUtilTest, MacTerminateOnHeapCorruption) {
   // Note that base::EnableTerminationOnHeapCorruption() is called as part of
   // test suite setup and does not need to be done again, else mach_override
   // will fail.
 
-  char buf[3];
-  ASSERT_DEATH(free(buf), "being freed.*"
+  // Test that ENOMEM doesn't crash. "I just want to allocate 1 petabyte."
+  void* buf = malloc(pow(10, 15));

[Scott Hess - ex-Googler, 2012/03/05 20:34:20]

This isn't really 32-bit safe, is it?  It just happens to be 2764472320 on
32-bit, and I see failures above 2^31.  If that was intentional, I think you
should code it more intentionally.

Well, also, 1<<50 would let you get away without cmath.  Or (size_t)(-1).

[Robert Sesek, 2012/03/06 01:16:27]

Done in a C++ way.

+  EXPECT_FALSE(buf);
+  EXPECT_EQ(ENOMEM, errno) << "Expected no memory error";

[Scott Hess - ex-Googler, 2012/03/05 20:34:20]

Is the death-test below considered proof enough that CrMallocErrorBreak() has
been installed?

[Robert Sesek, 2012/03/06 01:16:27]

Yes.

+
+  char stack_buf[3];
+  ASSERT_DEATH(free(stack_buf), "being freed.*"
       "\\*\\*\\* set a breakpoint in malloc_error_break to debug.*"
       "Terminating process due to a potential for future heap corruption");
 }
 
 #endif  // defined(OS_MACOSX)
 
 #if defined(OS_POSIX)
 
 namespace {
 
@@ skipping 681 matching lines @@
       SetUpInDeathAssert();
       while ((value_ = base::AllocatePsychoticallyBigObjCObject())) {}
     }, "");
 }
 
 #endif  // !ARCH_CPU_64_BITS
 #endif  // OS_MACOSX
 
 #endif  // !defined(OS_ANDROID) && !defined(OS_OPENBSD) &&
         // !defined(OS_WIN) && !defined(ADDRESS_SANITIZER)