Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 9597017: Fix inlining of strict mode constructors. (Closed)

Created:
8 years, 9 months ago by Michael Starzinger
Modified:
8 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix inlining of strict mode constructors. Inlined strict mode functions (that are not called as methods) will get their receiver reset to undefined. This should not happen when inlining constructors. This change also simplifies the test suite to reuse the same closures into which constructors get inlined and use gc() to force V8 to forget collected type feedback. R=vegorov@chromium.org TEST=mjsunit/compiler/inline-construct Committed: https://code.google.com/p/v8/source/detail?r=10920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -57 lines) Patch
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/inline-construct.js View 5 chunks +38 lines, -56 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
8 years, 9 months ago (2012-03-05 12:39:06 UTC) #1
Vyacheslav Egorov (Chromium)
8 years, 9 months ago (2012-03-05 12:41:51 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698