Issue 9597003: Replace an usage of ScopedSkRegion with our implementation of scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9597003: Replace an usage of ScopedSkRegion with our implementation of scoped_ptr. (Closed)

Created:
8 years, 9 months ago by tfarina

Modified:
8 years, 9 months ago

Reviewers:
jam

CC:
chromium-reviews, yusukes+watch_chromium.org, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Replace an usage of ScopedSkRegion with our implementation of scoped_ptr. R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124979

Patch Set 1 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_win.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	content/browser/renderer_host/render_widget_host_view_win.cc	View		4 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

On 2012/03/05 06:57:05, John Abd-El-Malek wrote: > What is the reason for this change? I ...

8 years, 9 months ago (2012-03-05 12:20:22 UTC) #3

jam

8 years, 9 months ago (2012-03-05 19:19:01 UTC) #4

On 2012/03/05 12:20:22, tfarina wrote:
> On 2012/03/05 06:57:05, John Abd-El-Malek wrote:
> > What is the reason for this change?
> 
> I plan to get rid of ScopedSkRegion, because it's pointless to have it. It's
re
> implementing scoped_ptr.

got it. lgtm

Expand Messages | Collapse Messages