Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: chrome/common/net/gaia/oauth2_mint_token_fetcher.h

Issue 9596001: Coverity: Fix pass-by-value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/common/net/gaia/oauth2_mint_token_fetcher.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_NET_GAIA_OAUTH2_MINT_TOKEN_FETCHER_H_ 5 #ifndef CHROME_COMMON_NET_GAIA_OAUTH2_MINT_TOKEN_FETCHER_H_
6 #define CHROME_COMMON_NET_GAIA_OAUTH2_MINT_TOKEN_FETCHER_H_ 6 #define CHROME_COMMON_NET_GAIA_OAUTH2_MINT_TOKEN_FETCHER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 INITIAL, 62 INITIAL,
63 MINT_TOKEN_STARTED, 63 MINT_TOKEN_STARTED,
64 MINT_TOKEN_DONE, 64 MINT_TOKEN_DONE,
65 ERROR_STATE, 65 ERROR_STATE,
66 }; 66 };
67 67
68 // Helper methods for the flow. 68 // Helper methods for the flow.
69 void StartMintToken(); 69 void StartMintToken();
70 void EndMintToken(const content::URLFetcher* source); 70 void EndMintToken(const content::URLFetcher* source);
71 71
72 // Helper mehtods for reporting back results. 72 // Helper methods for reporting back results.
73 void OnMintTokenSuccess(const std::string& access_token); 73 void OnMintTokenSuccess(const std::string& access_token);
74 void OnMintTokenFailure(GoogleServiceAuthError error); 74 void OnMintTokenFailure(const GoogleServiceAuthError& error);
75 75
76 // Other helpers. 76 // Other helpers.
77 static GURL MakeMintTokenUrl(); 77 static GURL MakeMintTokenUrl();
78 static std::string MakeMintTokenHeader(const std::string& access_token); 78 static std::string MakeMintTokenHeader(const std::string& access_token);
79 static std::string MakeMintTokenBody(const std::string& client_id, 79 static std::string MakeMintTokenBody(const std::string& client_id,
80 const std::vector<std::string>& scopes, 80 const std::vector<std::string>& scopes,
81 const std::string& origin); 81 const std::string& origin);
82 static bool ParseMintTokenResponse(const content::URLFetcher* source, 82 static bool ParseMintTokenResponse(const content::URLFetcher* source,
83 std::string* access_token); 83 std::string* access_token);
84 84
(...skipping 11 matching lines...) Expand all
96 std::string origin_; 96 std::string origin_;
97 97
98 friend class OAuth2MintTokenFetcherTest; 98 friend class OAuth2MintTokenFetcherTest;
99 FRIEND_TEST_ALL_PREFIXES(OAuth2MintTokenFetcherTest, 99 FRIEND_TEST_ALL_PREFIXES(OAuth2MintTokenFetcherTest,
100 ParseMintTokenResponse); 100 ParseMintTokenResponse);
101 101
102 DISALLOW_COPY_AND_ASSIGN(OAuth2MintTokenFetcher); 102 DISALLOW_COPY_AND_ASSIGN(OAuth2MintTokenFetcher);
103 }; 103 };
104 104
105 #endif // CHROME_COMMON_NET_GAIA_OAUTH2_MINT_TOKEN_FETCHER_H_ 105 #endif // CHROME_COMMON_NET_GAIA_OAUTH2_MINT_TOKEN_FETCHER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/common/net/gaia/oauth2_mint_token_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698