Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 959553002: Update the Style Guide (Closed)

Created:
5 years, 10 months ago by Kathy Walrath
Modified:
5 years, 10 months ago
Reviewers:
Bob Nystrom
Base URL:
https://github.com/dart-lang/www.dartlang.org.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 7

Patch Set 2 : incorporate reviewer comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -4 lines) Patch
M src/site/articles/style-guide/index.markdown View 1 5 chunks +92 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Kathy Walrath
5 years, 10 months ago (2015-02-25 01:21:27 UTC) #2
Bob Nystrom
https://chromiumcodereview.appspot.com/959553002/diff/1/src/site/articles/style-guide/index.markdown File src/site/articles/style-guide/index.markdown (right): https://chromiumcodereview.appspot.com/959553002/diff/1/src/site/articles/style-guide/index.markdown#newcode1063 src/site/articles/style-guide/index.markdown:1063: whenTrue : whenFalse; Let's make this one: return someCondition ...
5 years, 10 months ago (2015-02-26 00:19:53 UTC) #3
Kathy Walrath
ptal https://chromiumcodereview.appspot.com/959553002/diff/1/src/site/articles/style-guide/index.markdown File src/site/articles/style-guide/index.markdown (right): https://chromiumcodereview.appspot.com/959553002/diff/1/src/site/articles/style-guide/index.markdown#newcode1063 src/site/articles/style-guide/index.markdown:1063: whenTrue : whenFalse; On 2015/02/26 00:19:52, Bob Nystrom ...
5 years, 10 months ago (2015-02-26 16:15:14 UTC) #4
Bob Nystrom
LGTM, thanks! https://chromiumcodereview.appspot.com/959553002/diff/1/src/site/articles/style-guide/index.markdown File src/site/articles/style-guide/index.markdown (right): https://chromiumcodereview.appspot.com/959553002/diff/1/src/site/articles/style-guide/index.markdown#newcode1625 src/site/articles/style-guide/index.markdown:1625: we recommend always specifying a library name. ...
5 years, 10 months ago (2015-02-26 20:52:03 UTC) #5
Kathy Walrath
5 years, 10 months ago (2015-02-26 23:36:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d312ffa75130ab440a88b6ecb9a4c60cc52e6a83 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698