Issue 9595027: Update suppression with RenderViewHostImpl change

Issue 9595027: Update suppression with RenderViewHostImpl change (Closed)

Created:
8 years, 9 months ago by dhollowa

Modified:
8 years, 9 months ago

Reviewers:
Jói

CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update suppression with RenderViewHostImpl change Update suppression with RenderViewHostImpl change r124941. BUG=98716 TEST=Valgrind goes green TBR=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124967

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tools/valgrind/drmemory/suppressions.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói

8 years, 9 months ago (2012-03-05 18:07:31 UTC) #2

LGTM

Oops, thanks a lot!

On Mon, Mar 5, 2012 at 6:06 PM,  <dhollowa@chromium.org> wrote:
> Reviewers: Jói,
>
> Description:
> Update suppression with RenderViewHostImpl change
>
> Update suppression with RenderViewHostImpl change r124941.
>
> BUG=98716
> TEST=Valgrind goes green
> TBR=joi@chromium.org
>
>
> Please review this at https://chromiumcodereview.appspot.com/9595027/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M tools/valgrind/drmemory/suppressions.txt
>  M tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/drmemory/suppressions.txt
> diff --git a/tools/valgrind/drmemory/suppressions.txt
> b/tools/valgrind/drmemory/suppressions.txt
> index
>
c79b2012a9538cbc48b2ed8e5d16e767b557dd56..b0035bdf24d118cb0c49119ff67c6215b3d14663
> 100644
> --- a/tools/valgrind/drmemory/suppressions.txt
> +++ b/tools/valgrind/drmemory/suppressions.txt
> @@ -1,7 +1,7 @@
>  # This file contains suppressions for the Dr.Memory tool, see
>  # http://dev.chromium.org/developers/how-tos/using-drmemory
>  #
> -# This file contains suppressions for the DrMemroy reports happening
> +# This file contains suppressions for the DrMemory reports happening
>  # in the 'light' mode (a.k.a. drmemory_light) as well as in the 'full'
> mode.
>  # Please use suppressions_full.txt for all the reports that can happen only
>  # in the full mode (drmemory_full),
> Index: tools/valgrind/memcheck/suppressions.txt
> diff --git a/tools/valgrind/memcheck/suppressions.txt
> b/tools/valgrind/memcheck/suppressions.txt
> index
>
7d97b5f1b193fcc91ca770864c01ed9d1421bb0b..1ba9cd699629c766a69378c616e58debb40ef131
> 100644
> --- a/tools/valgrind/memcheck/suppressions.txt
> +++ b/tools/valgrind/memcheck/suppressions.txt
> @@ -3338,7 +3338,7 @@
>    ...
>
>
 fun:_ZN6chrome26ChromeContentBrowserClient24RenderProcessHostCreatedEPN7content17RenderProcessHostE
>    fun:_ZN21RenderProcessHostImpl4InitEb
> -   fun:_ZN14RenderViewHost16CreateRenderView*
> +   fun:_ZN18RenderViewHostImpl16CreateRenderView*
>    fun:_ZN11TabContents32CreateRenderViewForRenderManagerEP14RenderViewHost
>
>
 fun:_ZN21RenderViewHostManager14InitRenderViewEP14RenderViewHostRKN7content19NavigationEntryImplE
>    ...
>
>

Expand Messages | Collapse Messages