Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: webkit/plugins/ppapi/ppb_video_capture_impl.h

Issue 9595004: Coverity: Fix several pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ppapi/thunk/ppb_video_capture_api.h ('k') | webkit/plugins/ppapi/ppb_video_capture_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_PLUGINS_PPAPI_PPB_VIDEO_CAPTURE_IMPL_H_ 5 #ifndef WEBKIT_PLUGINS_PPAPI_PPB_VIDEO_CAPTURE_IMPL_H_
6 #define WEBKIT_PLUGINS_PPAPI_PPB_VIDEO_CAPTURE_IMPL_H_ 6 #define WEBKIT_PLUGINS_PPAPI_PPB_VIDEO_CAPTURE_IMPL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 const media::VideoCaptureParams& device_info) OVERRIDE; 46 const media::VideoCaptureParams& device_info) OVERRIDE;
47 virtual void OnInitialized(media::VideoCapture* capture, 47 virtual void OnInitialized(media::VideoCapture* capture,
48 bool succeeded) OVERRIDE; 48 bool succeeded) OVERRIDE;
49 49
50 private: 50 private:
51 typedef std::vector< ::ppapi::DeviceRefData> DeviceRefDataVector; 51 typedef std::vector< ::ppapi::DeviceRefData> DeviceRefDataVector;
52 52
53 // PPB_VideoCapture_Shared implementation. 53 // PPB_VideoCapture_Shared implementation.
54 virtual int32_t InternalEnumerateDevices( 54 virtual int32_t InternalEnumerateDevices(
55 PP_Resource* devices, 55 PP_Resource* devices,
56 PP_CompletionCallback callback) OVERRIDE; 56 const PP_CompletionCallback& callback) OVERRIDE;
57 virtual int32_t InternalOpen( 57 virtual int32_t InternalOpen(
58 const std::string& device_id, 58 const std::string& device_id,
59 const PP_VideoCaptureDeviceInfo_Dev& requested_info, 59 const PP_VideoCaptureDeviceInfo_Dev& requested_info,
60 uint32_t buffer_count, 60 uint32_t buffer_count,
61 PP_CompletionCallback callback) OVERRIDE; 61 const PP_CompletionCallback& callback) OVERRIDE;
62 virtual int32_t InternalStartCapture() OVERRIDE; 62 virtual int32_t InternalStartCapture() OVERRIDE;
63 virtual int32_t InternalReuseBuffer(uint32_t buffer) OVERRIDE; 63 virtual int32_t InternalReuseBuffer(uint32_t buffer) OVERRIDE;
64 virtual int32_t InternalStopCapture() OVERRIDE; 64 virtual int32_t InternalStopCapture() OVERRIDE;
65 virtual void InternalClose() OVERRIDE; 65 virtual void InternalClose() OVERRIDE;
66 virtual int32_t InternalStartCapture0_1( 66 virtual int32_t InternalStartCapture0_1(
67 const PP_VideoCaptureDeviceInfo_Dev& requested_info, 67 const PP_VideoCaptureDeviceInfo_Dev& requested_info,
68 uint32_t buffer_count) OVERRIDE; 68 uint32_t buffer_count) OVERRIDE;
69 virtual const DeviceRefDataVector& InternalGetDeviceRefData() const OVERRIDE; 69 virtual const DeviceRefDataVector& InternalGetDeviceRefData() const OVERRIDE;
70 70
71 void ReleaseBuffers(); 71 void ReleaseBuffers();
(...skipping 27 matching lines...) Expand all
99 99
100 media::VideoCapture::VideoCaptureCapability capability_; 100 media::VideoCapture::VideoCaptureCapability capability_;
101 101
102 DISALLOW_COPY_AND_ASSIGN(PPB_VideoCapture_Impl); 102 DISALLOW_COPY_AND_ASSIGN(PPB_VideoCapture_Impl);
103 }; 103 };
104 104
105 } // namespace ppapi 105 } // namespace ppapi
106 } // namespace webkit 106 } // namespace webkit
107 107
108 #endif // WEBKIT_PLUGINS_PPAPI_PPB_VIDEO_CAPTURE_IMPL_H_ 108 #endif // WEBKIT_PLUGINS_PPAPI_PPB_VIDEO_CAPTURE_IMPL_H_
OLDNEW
« no previous file with comments | « ppapi/thunk/ppb_video_capture_api.h ('k') | webkit/plugins/ppapi/ppb_video_capture_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698