Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: ppapi/shared_impl/ppb_video_capture_shared.h

Issue 9595004: Coverity: Fix several pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ppapi/proxy/ppb_video_capture_proxy.cc ('k') | ppapi/shared_impl/ppb_video_capture_shared.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PPAPI_SHARED_IMPL_PPB_VIDEO_CAPTURE_SHARED_H_ 5 #ifndef PPAPI_SHARED_IMPL_PPB_VIDEO_CAPTURE_SHARED_H_
6 #define PPAPI_SHARED_IMPL_PPB_VIDEO_CAPTURE_SHARED_H_ 6 #define PPAPI_SHARED_IMPL_PPB_VIDEO_CAPTURE_SHARED_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "ppapi/shared_impl/ppapi_shared_export.h" 11 #include "ppapi/shared_impl/ppapi_shared_export.h"
12 #include "ppapi/shared_impl/resource.h" 12 #include "ppapi/shared_impl/resource.h"
13 #include "ppapi/shared_impl/tracked_callback.h" 13 #include "ppapi/shared_impl/tracked_callback.h"
14 #include "ppapi/thunk/ppb_video_capture_api.h" 14 #include "ppapi/thunk/ppb_video_capture_api.h"
15 15
16 namespace ppapi { 16 namespace ppapi {
17 17
18 class PPAPI_SHARED_EXPORT PPB_VideoCapture_Shared 18 class PPAPI_SHARED_EXPORT PPB_VideoCapture_Shared
19 : public Resource, 19 : public Resource,
20 NON_EXPORTED_BASE(public thunk::PPB_VideoCapture_API) { 20 NON_EXPORTED_BASE(public thunk::PPB_VideoCapture_API) {
21 public: 21 public:
22 explicit PPB_VideoCapture_Shared(PP_Instance instance); 22 explicit PPB_VideoCapture_Shared(PP_Instance instance);
23 explicit PPB_VideoCapture_Shared(const HostResource& host_resource); 23 explicit PPB_VideoCapture_Shared(const HostResource& host_resource);
24 virtual ~PPB_VideoCapture_Shared(); 24 virtual ~PPB_VideoCapture_Shared();
25 25
26 // Resource overrides. 26 // Resource implementation.
27 virtual thunk::PPB_VideoCapture_API* AsPPB_VideoCapture_API() OVERRIDE; 27 virtual thunk::PPB_VideoCapture_API* AsPPB_VideoCapture_API() OVERRIDE;
28 28
29 // PPB_VideoCapture_API implementation. 29 // PPB_VideoCapture_API implementation.
30 virtual int32_t EnumerateDevices(PP_Resource* devices, 30 virtual int32_t EnumerateDevices(
31 PP_CompletionCallback callback) OVERRIDE; 31 PP_Resource* devices,
32 const PP_CompletionCallback& callback) OVERRIDE;
32 virtual int32_t Open(const std::string& device_id, 33 virtual int32_t Open(const std::string& device_id,
33 const PP_VideoCaptureDeviceInfo_Dev& requested_info, 34 const PP_VideoCaptureDeviceInfo_Dev& requested_info,
34 uint32_t buffer_count, 35 uint32_t buffer_count,
35 PP_CompletionCallback callback) OVERRIDE; 36 const PP_CompletionCallback& callback) OVERRIDE;
36 virtual int32_t StartCapture() OVERRIDE; 37 virtual int32_t StartCapture() OVERRIDE;
37 virtual int32_t ReuseBuffer(uint32_t buffer) OVERRIDE; 38 virtual int32_t ReuseBuffer(uint32_t buffer) OVERRIDE;
38 virtual int32_t StopCapture() OVERRIDE; 39 virtual int32_t StopCapture() OVERRIDE;
39 virtual void Close() OVERRIDE; 40 virtual void Close() OVERRIDE;
40 virtual int32_t StartCapture0_1( 41 virtual int32_t StartCapture0_1(
41 const PP_VideoCaptureDeviceInfo_Dev& requested_info, 42 const PP_VideoCaptureDeviceInfo_Dev& requested_info,
42 uint32_t buffer_count) OVERRIDE; 43 uint32_t buffer_count) OVERRIDE;
43 virtual const std::vector<DeviceRefData>& GetDeviceRefData() const OVERRIDE; 44 virtual const std::vector<DeviceRefData>& GetDeviceRefData() const OVERRIDE;
44 45
45 void OnEnumerateDevicesComplete(int32_t result, 46 void OnEnumerateDevicesComplete(int32_t result,
46 const std::vector<DeviceRefData>& devices); 47 const std::vector<DeviceRefData>& devices);
47 void OnOpenComplete(int32_t result); 48 void OnOpenComplete(int32_t result);
48 49
49 protected: 50 protected:
50 enum OpenState { 51 enum OpenState {
51 BEFORE_OPEN, 52 BEFORE_OPEN,
52 OPENED, 53 OPENED,
53 CLOSED 54 CLOSED
54 }; 55 };
55 56
56 // Subclasses should implement these methods to do impl- and proxy-specific 57 // Subclasses should implement these methods to do impl- and proxy-specific
57 // work. 58 // work.
58 virtual int32_t InternalEnumerateDevices(PP_Resource* devices, 59 virtual int32_t InternalEnumerateDevices(
59 PP_CompletionCallback callback) = 0; 60 PP_Resource* devices,
61 const PP_CompletionCallback& callback) = 0;
60 virtual int32_t InternalOpen( 62 virtual int32_t InternalOpen(
61 const std::string& device_id, 63 const std::string& device_id,
62 const PP_VideoCaptureDeviceInfo_Dev& requested_info, 64 const PP_VideoCaptureDeviceInfo_Dev& requested_info,
63 uint32_t buffer_count, 65 uint32_t buffer_count,
64 PP_CompletionCallback callback) = 0; 66 const PP_CompletionCallback& callback) = 0;
65 virtual int32_t InternalStartCapture() = 0; 67 virtual int32_t InternalStartCapture() = 0;
66 virtual int32_t InternalReuseBuffer(uint32_t buffer) = 0; 68 virtual int32_t InternalReuseBuffer(uint32_t buffer) = 0;
67 virtual int32_t InternalStopCapture() = 0; 69 virtual int32_t InternalStopCapture() = 0;
68 virtual void InternalClose() = 0; 70 virtual void InternalClose() = 0;
69 virtual int32_t InternalStartCapture0_1( 71 virtual int32_t InternalStartCapture0_1(
70 const PP_VideoCaptureDeviceInfo_Dev& requested_info, 72 const PP_VideoCaptureDeviceInfo_Dev& requested_info,
71 uint32_t buffer_count) = 0; 73 uint32_t buffer_count) = 0;
72 virtual const std::vector<DeviceRefData>& InternalGetDeviceRefData( 74 virtual const std::vector<DeviceRefData>& InternalGetDeviceRefData(
73 ) const = 0; 75 ) const = 0;
74 76
(...skipping 14 matching lines...) Expand all
89 91
90 ResourceObjectType resource_object_type_; 92 ResourceObjectType resource_object_type_;
91 93
92 private: 94 private:
93 DISALLOW_COPY_AND_ASSIGN(PPB_VideoCapture_Shared); 95 DISALLOW_COPY_AND_ASSIGN(PPB_VideoCapture_Shared);
94 }; 96 };
95 97
96 } // namespace ppapi 98 } // namespace ppapi
97 99
98 #endif // PPAPI_SHARED_IMPL_PPB_VIDEO_CAPTURE_SHARED_H_ 100 #endif // PPAPI_SHARED_IMPL_PPB_VIDEO_CAPTURE_SHARED_H_
OLDNEW
« no previous file with comments | « ppapi/proxy/ppb_video_capture_proxy.cc ('k') | ppapi/shared_impl/ppb_video_capture_shared.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698