Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Unified Diff: chrome/browser/extensions/pending_extension_info.h

Issue 9595001: Apps on NTP should be in order of installation (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: More fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/pending_extension_info.h
diff --git a/chrome/browser/extensions/pending_extension_info.h b/chrome/browser/extensions/pending_extension_info.h
index 7ab82d4dd8fa56e0ec9e1f2f287fbe394866b2d7..13d6d3f9f2be117f18409506a6a53670d7e35960 100644
--- a/chrome/browser/extensions/pending_extension_info.h
+++ b/chrome/browser/extensions/pending_extension_info.h
@@ -21,6 +21,7 @@ class PendingExtensionInfo {
typedef bool (*ShouldAllowInstallPredicate)(const Extension&);
PendingExtensionInfo(
+ const std::string& id,
const GURL& update_url,
ShouldAllowInstallPredicate should_allow_install,
bool is_from_sync,
@@ -30,6 +31,7 @@ class PendingExtensionInfo {
// Required for STL container membership. Should not be used directly.
PendingExtensionInfo();
+ const std::string& id() const { return id_; }
const GURL& update_url() const { return update_url_; }
// ShouldAllowInstall() returns the result of running constructor argument
@@ -46,6 +48,8 @@ class PendingExtensionInfo {
Extension::Location install_source() const { return install_source_; }
private:
+ const std::string& id_;
Aaron Boodman 2012/05/01 15:50:22 No need for this to be const since it is private.
mitchellwrosen 2012/05/11 05:45:03 Compiler barks about initializing a non-const std:
Aaron Boodman 2012/05/11 19:23:55 It should work if its non-reference. Just plain ol
+
GURL update_url_;
// When the extension is about to be installed, this function is

Powered by Google App Engine
This is Rietveld 408576698