Apps on NTP should be in order of installation

chrome/browser/sync/test/integration/sync_extension_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/test/integration/sync_extension_helper.h"
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/values.h"
@@ skipping 114 matching lines @@
 bool SyncExtensionHelper::IsIncognitoEnabled(
     Profile* profile, const std::string& name) const {
   return profile->GetExtensionService()->IsIncognitoEnabled(NameToId(name));
 }
 
 
 bool SyncExtensionHelper::IsExtensionPendingInstallForSync(
     Profile* profile, const std::string& id) const {
   const PendingExtensionManager* pending_extension_manager =
       profile->GetExtensionService()->pending_extension_manager();
-  PendingExtensionInfo info;
-  if (!pending_extension_manager->GetById(id, &info)) {
+  const PendingExtensionInfo* info = pending_extension_manager->GetById(id);
+  if (!info)
     return false;
-  }
-  return info.is_from_sync();
+  return info->is_from_sync();
 }
 
 void SyncExtensionHelper::InstallExtensionsPendingForSync(
     Profile* profile, Extension::Type type) {
   // TODO(akalin): Mock out the servers that the extensions auto-update
   // mechanism talk to so as to more closely match what actually happens.
   // Background networking will need to be re-enabled for extensions tests.
 
   // We make a copy here since InstallExtension() removes the
   // extension from the extensions service's copy.
   const PendingExtensionManager* pending_extension_manager =
       profile->GetExtensionService()->pending_extension_manager();
 
-  std::set<std::string> pending_crx_ids;
+  std::list<std::string> pending_crx_ids;
   pending_extension_manager->GetPendingIdsForUpdateCheck(&pending_crx_ids);
 
-  std::set<std::string>::const_iterator id;
-  PendingExtensionInfo info;
-  for (id = pending_crx_ids.begin(); id != pending_crx_ids.end(); ++id) {
-    ASSERT_TRUE(pending_extension_manager->GetById(*id, &info));
-    if (!info.is_from_sync())
+  std::list<std::string>::const_iterator iter;
+  const PendingExtensionInfo* info = NULL;
+  for (iter = pending_crx_ids.begin(); iter != pending_crx_ids.end(); ++iter) {
+    ASSERT_TRUE((info = pending_extension_manager->GetById(*iter)));
+    if (!info->is_from_sync())
       continue;
 
-    StringMap::const_iterator it2 = id_to_name_.find(*id);
-    if (it2 == id_to_name_.end()) {
-      ADD_FAILURE() << "Could not get name for id " << *id
+    StringMap::const_iterator iter2 = id_to_name_.find(*iter);
+    if (iter2 == id_to_name_.end()) {
+      ADD_FAILURE() << "Could not get name for id " << *iter
                     << " (profile = " << profile->GetDebugName() << ")";
       continue;
     }
-    InstallExtension(profile, it2->second, type);
+    InstallExtension(profile, iter2->second, type);
   }
 }
 
 SyncExtensionHelper::ExtensionStateMap
     SyncExtensionHelper::GetExtensionStates(Profile* profile) {
   const std::string& profile_debug_name = profile->GetDebugName();
 
   ExtensionStateMap extension_state_map;
 
   ExtensionService* extension_service = profile->GetExtensionService();
@@ skipping 12 matching lines @@
 
     DVLOG(2) << "Extension " << (*it)->id() << " in profile "
              << profile_debug_name << " is "
              << (extension_service->IsExtensionEnabled(id) ?
                  "enabled" : "disabled");
   }
 
   const PendingExtensionManager* pending_extension_manager =
       extension_service->pending_extension_manager();
 
-  std::set<std::string> pending_crx_ids;
+  std::list<std::string> pending_crx_ids;
   pending_extension_manager->GetPendingIdsForUpdateCheck(&pending_crx_ids);
 
-  std::set<std::string>::const_iterator id;
+  std::list<std::string>::const_iterator id;
   for (id = pending_crx_ids.begin(); id != pending_crx_ids.end(); ++id) {
     extension_state_map[*id].enabled_state = ExtensionState::PENDING;
     extension_state_map[*id].incognito_enabled =
         extension_service->IsIncognitoEnabled(*id);
     DVLOG(2) << "Extension " << *id << " in profile "
              << profile_debug_name << " is pending";
   }
 
   return extension_state_map;
 }
@@ skipping 131 matching lines @@
   if (extension->id() != expected_id) {
     EXPECT_EQ(expected_id, extension->id());
     return NULL;
   }
   DVLOG(2) << "created extension with name = "
            << name << ", id = " << expected_id;
   (it->second)[name] = extension;
   id_to_name_[expected_id] = name;
   return extension;
 }