Issue 9594037: Revert 124975 - [filebrowser] Introduce "Open" action for supported file types (e.g. pdf).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9594037: Revert 124975 - [filebrowser] Introduce "Open" action for supported file types (e.g. pdf). (Closed)

Created:
8 years, 9 months ago by Dan Beam

Modified:
8 years, 9 months ago

Reviewers:
dgozman

CC:
chromium-reviews, nkostylev+watch_chromium.org, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 124975 - [filebrowser] Introduce "Open" action for supported file types (e.g. pdf). Was breaking ChromeOS, failing tests were: - FileSystemExtensionApiTest.FileBrowserTest - FileSystemExtensionApiTest.FileBrowserTestWrite - FileSystemExtensionApiTest.FileBrowserTestWriteComponent BUG=chromium-os:26538, chromium-os:26539 TEST=See bug. Review URL: http://codereview.chromium.org/9395077 TBR=dgozman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125002

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -89 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager_util.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager_util.cc	View	2 chunks	+23 lines, -23 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	3 chunks	+3 lines, -21 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/mock_chrome.js	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/file_manager/manifest.json	View	1 chunk	+1 line, -26 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages