Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: vm/class_finalizer.h

Issue 9594028: Add a first class GrowableObjectArray type in the VM and use it internally in the VM at all spots w… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | vm/class_finalizer.cc » ('j') | vm/class_finalizer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/class_finalizer.h
===================================================================
--- vm/class_finalizer.h (revision 4983)
+++ vm/class_finalizer.h (working copy)
@@ -15,6 +15,7 @@
class Class;
class Error;
class Function;
+class GrowableObjectArray;
class RawAbstractType;
class RawClass;
class RawType;
@@ -37,8 +38,8 @@
// Return false if 'interface' conflicts with an interface already in the list
// with the same class, but different type arguments.
// In the case of a conflict, set 'conflicting' to the existing interface.
- static bool AddInterfaceIfUnique(GrowableArray<AbstractType*>* interface_list,
- AbstractType* interface,
+ static bool AddInterfaceIfUnique(const GrowableObjectArray& interface_list,
+ const AbstractType& interface,
AbstractType* conflicting);
// Modes for type resolution and finalization. The ordering is relevant.
@@ -66,9 +67,6 @@
FinalizationKind finalization,
const char* format, ...);
- // Pending classes are classes that need to be finalized.
- static void AddPendingClasses(const GrowableArray<const Class*>& classes);
-
// Return false if we still have classes pending to be finalized.
static bool AllClassesFinalized();
@@ -97,7 +95,7 @@
static void ResolveSuperType(const Class& cls);
static void ResolveDefaultClass(const Class& cls);
static void ResolveInterfaces(const Class& cls,
- GrowableArray<const Class*>* visited);
+ const GrowableObjectArray& visited);
static void FinalizeTypeArguments(const Class& cls,
const AbstractTypeArguments& arguments,
FinalizationKind finalization);
@@ -111,7 +109,7 @@
static void PrintClassInformation(const Class& cls);
static void VerifyClassImplements(const Class& cls);
static void CollectInterfaces(const Class& cls,
- GrowableArray<const Class*>* interfaces);
+ const GrowableObjectArray& interfaces);
static void ReportError(const Error& error);
static void ReportError(const Script& script,
intptr_t token_index,
« no previous file with comments | « no previous file | vm/class_finalizer.cc » ('j') | vm/class_finalizer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698