Add a first class GrowableObjectArray type in the VM and use it internally in the VM at all spots w…

vm/object_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
@@ skipping 1721 matching lines @@
 
   other_array = Array::New(kArrayLen - 1);
   other_array.SetAt(0, array);
   other_array.SetAt(2, array);
   EXPECT(!array.Equals(other_array));
 
   EXPECT_EQ(0, Array::Handle(Array::Empty()).Length());
 }
 
 
+TEST_CASE(GrowableObjectArray) {
+  const int kArrayLen = 5;
+  Smi& value = Smi::Handle();
+  Smi& expected_value = Smi::Handle();
+  GrowableObjectArray& array = GrowableObjectArray::Handle();
+
+  // Test basic growing functionality.
+  array = GrowableObjectArray::New(kArrayLen);
+  EXPECT_EQ(kArrayLen, array.Capacity());
+  EXPECT_EQ(0, array.Length());
+  for (intptr_t i = 0; i < 10; i++) {
+    value = Smi::New(i);
+    array.Add(value);
+  }
+  EXPECT_EQ(10, array.Length());
+  for (intptr_t i = 0; i < 10; i++) {
+    expected_value = Smi::New(i);
+    value ^= array.At(i);
+    EXPECT(value.Equals(expected_value));
+  }
+  for (intptr_t i = 0; i < 10; i++) {
+    value = Smi::New(i * 10);
+    array.SetAt(i, value);
+  }
+  EXPECT_EQ(10, array.Length());
+  for (intptr_t i = 0; i < 10; i++) {
+    expected_value = Smi::New(i * 10);
+    value ^= array.At(i);
+    EXPECT(value.Equals(expected_value));
+  }
+
+  // Test the MakeArray functionality to make sure the resulting array
+  // object is properly setup.
+  // 1. Should produce an array of length 2 and a remainder array of length 0.
+  Array& new_array = Array::Handle();
+  Object& obj = Object::Handle();
+  uword addr = 0;
+  intptr_t used_size = 0;
+
+  array = GrowableObjectArray::New(kArrayLen);
+  EXPECT_EQ(kArrayLen, array.Capacity());
+  EXPECT_EQ(0, array.Length());
+  for (intptr_t i = 0; i < 2; i++) {
+    value = Smi::New(i);
+    array.Add(value);
+  }
+  used_size = Array::InstanceSize(array.Length());
+  new_array = Array::MakeArray(array);
+  addr = RawObject::ToAddr(new_array.raw());
+  obj = RawObject::FromAddr(addr);
+  EXPECT(obj.IsArray());
+  new_array ^= obj.raw();
+  EXPECT_EQ(2, new_array.Length());
+  addr += used_size;
+  obj = RawObject::FromAddr(addr);
+  EXPECT(obj.IsArray());
+  new_array ^= obj.raw();
+  EXPECT_EQ(0, new_array.Length());
+
+  // 2. Should produce an array of length 3 and a remainder object.
+  array = GrowableObjectArray::New(kArrayLen);
+  EXPECT_EQ(kArrayLen, array.Capacity());
+  EXPECT_EQ(0, array.Length());
+  for (intptr_t i = 0; i < 3; i++) {
+    value = Smi::New(i);
+    array.Add(value);
+  }
+  used_size = Array::InstanceSize(array.Length());
+  new_array = Array::MakeArray(array);
+  addr = RawObject::ToAddr(new_array.raw());
+  obj = RawObject::FromAddr(addr);
+  EXPECT(obj.IsArray());
+  new_array ^= obj.raw();
+  EXPECT_EQ(3, new_array.Length());
+  addr += used_size;
+  obj = RawObject::FromAddr(addr);
+  EXPECT(!obj.IsArray());
+
+  // 3. Should produce an array of length 1 and a remainder array of length 2.
+  array = GrowableObjectArray::New(kArrayLen + 3);
+  EXPECT_EQ((kArrayLen + 3), array.Capacity());
+  EXPECT_EQ(0, array.Length());
+  for (intptr_t i = 0; i < 1; i++) {
+    value = Smi::New(i);
+    array.Add(value);
+  }
+  used_size = Array::InstanceSize(array.Length());
+  new_array = Array::MakeArray(array);
+  addr = RawObject::ToAddr(new_array.raw());
+  obj = RawObject::FromAddr(addr);
+  EXPECT(obj.IsArray());
+  new_array ^= obj.raw();
+  EXPECT_EQ(1, new_array.Length());
+  addr += used_size;
+  obj = RawObject::FromAddr(addr);
+  EXPECT(obj.IsArray());
+  new_array ^= obj.raw();
+  EXPECT_EQ(2, new_array.Length());
+}
+
+
 TEST_CASE(ExternalByteArray) {
   uint8_t data[] = { 253, 254, 255, 0, 1, 2, 3, 4 };
   intptr_t data_length = ARRAY_SIZE(data);
 
   const ExternalByteArray& array1 =
       ExternalByteArray::Handle(ExternalByteArray::New(data,
                                                        data_length,
                                                        NULL,
                                                        NULL));
   EXPECT(!array1.IsNull());
@@ skipping 932 matching lines @@
   EXPECT_EQ(2, test_classes.length());
   EXPECT_EQ(smi_class.raw(), test_classes[0]->raw());
   EXPECT_EQ(smi_class.raw(), test_classes[1]->raw());
   EXPECT_EQ(target1.raw(), test_target.raw());
 }
 
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart