Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 9594013: Allocate new AccessorPairs with holes instead of undefined. (Closed)

Created:
8 years, 9 months ago by Sven Panne
Modified:
8 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Allocate new AccessorPairs with holes instead of undefined. This is essential for the upcoming map sharing with accessors, and we aleady have enough machinery to handle the holes now. Furthermore, use "To" template in 2 nearby functions, and made naming a bit more consistent. In a nutshell: This CL should have no visible effect at all at the moment. Famous last words... Committed: https://code.google.com/p/v8/source/detail?r=10919

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M src/heap.cc View 3 chunks +12 lines, -15 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 9 months ago (2012-03-05 09:49:56 UTC) #1
Michael Starzinger
8 years, 9 months ago (2012-03-05 11:48:05 UTC) #2
LGTM.

https://chromiumcodereview.appspot.com/9594013/diff/1/src/heap.cc
File src/heap.cc (right):

https://chromiumcodereview.appspot.com/9594013/diff/1/src/heap.cc#newcode1933
src/heap.cc:1933: accessors->set_setter(the_hole_value(), SKIP_WRITE_BARRIER);
It would be possible to add an AllocateStructWithFiller() that takes another
initial filler object (besides undefined). This would avoid two unnecessary
writes. But I suppose that's not worth the effort here. So I am fine with
leaving everything as it is.

Powered by Google App Engine
This is Rietveld 408576698