Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 9593001: Revert 124790 - Minimized panels should not open on Windows when activated by the OS (Closed)

Created:
8 years, 9 months ago by yzshen1
Modified:
8 years, 9 months ago
Reviewers:
Andrei
CC:
chromium-reviews, Dmitry Lomov (no reviews), jennb, Dmitry Titov, jianli, dcheng, Andrei
Visibility:
Public.

Description

Revert 124790 - Minimized panels should not open on Windows when activated by the OS Minimized panels are not "minimized" from the OS point of view so they may receive focus when other windows are minimized or closed. This patch sets the flags on the minimized panels in such way that they are not activated by the OS but still appear in the Alt-Tab menu and on the taskbar. BUG=102721 TEST=Manually verify that minimized panels do not open spontaneously when other windows are closed, but are accessible through the taskbar and Alt-Tab. Review URL: http://codereview.chromium.org/9463022 TBR=aburago@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -69 lines) Patch
M chrome/browser/ui/panels/detached_panel_strip.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/detached_panel_strip.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/panels/docked_panel_strip.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/docked_panel_strip.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/panels/native_panel.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/overflow_panel_strip.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/overflow_panel_strip.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/panels/panel.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_view.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_cocoa.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_cocoa.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_gtk.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/panels/panel_strip.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/panels/panel_window_controller_cocoa.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/panels/panel_window_controller_cocoa.mm View 3 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
yzshen1
8 years, 9 months ago (2012-03-03 00:53:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698