Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 9592037: Implement SequencedWorkerPool::RunsTasksOnCurrentThread() (Closed)

Created:
8 years, 9 months ago by akalin
Modified:
8 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Implement SequencedWorkerPool::RunsTasksOnCurrentThread() Store threads in a tid-indexed map instead of a vector. Use that to implement RunsTasksOnCurrentThread(). Expand TaskRunner test template to include test for RunsTasksOnCurrentThread(). Move some utility classes/functions for the TaskRunner test template into the internal namespace. BUG=114329, 114327 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -25 lines) Patch
M base/task_runner_test_template.h View 5 chunks +70 lines, -12 lines 0 comments Download
M base/task_runner_test_template.cc View 2 chunks +18 lines, -1 line 0 comments Download
M base/threading/sequenced_worker_pool.cc View 9 chunks +23 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
akalin
+brettw for review
8 years, 9 months ago (2012-03-07 02:26:07 UTC) #1
akalin
On 2012/03/07 02:26:07, akalin wrote: > +brettw for review ping!
8 years, 9 months ago (2012-03-07 21:13:18 UTC) #2
brettw
LGTM. Have you thought about putting the test template in base/test? This initially confused me ...
8 years, 9 months ago (2012-03-08 21:45:33 UTC) #3
akalin
8 years, 9 months ago (2012-03-09 04:23:05 UTC) #4
On 2012/03/08 21:45:33, brettw wrote:
> LGTM.
> 
> Have you thought about putting the test template in base/test? This initially
> confused me since I thought this was production code with an EXPECT in it.

Oh, that might be a better place to put it.  I'll do that in a separate CL.

Powered by Google App Engine
This is Rietveld 408576698