Eliminate IncrOpStaticFieldNode, replace a set of nodes.

runtime/vm/code_generator_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/code_generator.h"
 
 #include "lib/error.h"
@@ skipping 1189 matching lines @@
   __ pushl(EDX);  // Receiver.
   __ pushl(EAX);  // Value.
   // It is not necessary to generate a type test of the assigned value here,
   // because the setter will check the type of its incoming arguments.
   GenerateInstanceSetterCall(node->setter_id(),
                              node->token_index(),
                              node->field_name());
 }
 
 
-void CodeGenerator::VisitIncrOpStaticFieldNode(IncrOpStaticFieldNode* node) {
-  ASSERT((node->kind() == Token::kINCR) || (node->kind() == Token::kDECR));
-  MarkDeoptPoint(node->id(), node->token_index());
-  if (node->field().IsNull()) {
-    GenerateStaticGetterCall(node->token_index(),
-                             node->field_class(),
-                             node->field_name());
-  } else {
-    __ LoadObject(EDX, node->field());
-    __ movl(EAX, FieldAddress(EDX, Field::value_offset()));
-  }
-  // Value in EAX.
-  if (!node->prefix() && IsResultNeeded(node)) {
-    // Preserve as result.
-    __ pushl(EAX);
-  }
-  const Immediate value = Immediate(reinterpret_cast<int32_t>(Smi::New(1)));
-  const char* operator_name = (node->kind() == Token::kINCR) ? "+" : "-";
-  __ pushl(EAX);    // Left operand.
-  __ pushl(value);  // Right operand.
-  GenerateBinaryOperatorCall(node->id(), node->token_index(), operator_name);
-  // result is in EAX.
-  if (node->prefix() && IsResultNeeded(node)) {
-    __ pushl(EAX);
-  }
-  if (node->field().IsNull()) {
-    __ pushl(EAX);
-    // It is not necessary to generate a type test of the assigned value here,
-    // because the setter will check the type of its incoming arguments.
-    GenerateStaticSetterCall(node->token_index(),
-                             node->field_class(),
-                             node->field_name());
-  } else {
-    if (FLAG_enable_type_checks) {
-      GenerateAssertAssignable(node->id(),
-                               node->token_index(),
-                               AbstractType::ZoneHandle(node->field().type()),
-                               String::ZoneHandle(node->field().name()));
-    }
-    __ LoadObject(EDX, node->field());
-    __ StoreIntoObject(EDX, FieldAddress(EDX, Field::value_offset()), EAX);
-  }
-}
-
-
 void CodeGenerator::VisitIncrOpIndexedNode(IncrOpIndexedNode* node) {
   ASSERT((node->kind() == Token::kINCR) || (node->kind() == Token::kDECR));
   node->array()->Visit(this);
   node->index()->Visit(this);
   MarkDeoptPoint(node->id(), node->token_index());
   // Preserve array and index for GenerateStoreIndex.
   __ pushl(Address(ESP, kWordSize));  // Copy array.
   __ pushl(Address(ESP, kWordSize));  // Copy index.
   GenerateLoadIndexed(node->load_id(), node->token_index());
   // Result is in EAX.
@@ skipping 1451 matching lines @@
   const Error& error = Error::Handle(
       Parser::FormatError(script, token_index, "Error", format, args));
   va_end(args);
   Isolate::Current()->long_jump_base()->Jump(1, error);
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32