Issue 9588003: browser: Minor changes to use SkPoint::iset() function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9588003: browser: Minor changes to use SkPoint::iset() function. (Closed)

Created:
8 years, 9 months ago by tfarina

Modified:
8 years, 9 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -44 lines)			Patch
M	chrome/browser/chromeos/frame/panel_controller.cc	View	2 chunks	+10 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/infobar_background.cc	View	1 chunk	+4 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab.cc	View	1 chunk	+6 lines, -11 lines	0 comments	Download
M	ui/gfx/render_text.cc	View	2 chunks	+5 lines, -7 lines	0 comments	Download
M	ui/views/controls/glow_hover_controller.cc	View	1 chunk	+7 lines, -11 lines	0 comments	Download

Total messages: 2 (0 generated)

Peter Kasting

8 years, 9 months ago (2012-03-03 00:54:21 UTC) #2

LGTM; wonder if we should add a PointToSkPoint() converter like the one for
gfx::Rect to simplify some of these.