Remove an unneeded temp in instance setters and indexed stores.

runtime/vm/intermediate_language.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_INTERMEDIATE_LANGUAGE_H_
 #define VM_INTERMEDIATE_LANGUAGE_H_
 
 #include "vm/allocation.h"
 #include "vm/ast.h"
 #include "vm/growable_array.h"
 #include "vm/handles_impl.h"
 #include "vm/object.h"
 
 namespace dart {
 
 class FlowGraphVisitor;
 class LocalVariable;
 
 // Computations and values.
 //
 // <Computation> ::=
 //   <Value>
 // | AssertAssignable <Value> <AbstractType>
 // | InstanceCall <AstNode> <String> <Value> ...
 // | StaticCall <StaticCallNode> <Value> ...
 // | LoadLocal <LocalVariable>
 // | StoreLocal <LocalVariable> <Value>
-// | StoreIndexed <Value> <Value> <Value> <Value>
 // | StrictCompare <Token::kind> <Value> <Value>
 // | NativeCall <NativeBodyNode>
+// | StoreIndexed <StoreIndexedNode> <Value> <Value> <Value>
+// | InstanceSetter <InstanceSetterNode> <Value> <Value>
 //
 // <Value> ::=
 //   Temp <int>
 // | Constant <Instance>
 
 // M is a two argument macro.  It is applied to each concrete value's
 // typename and classname.
 #define FOR_EACH_VALUE(M)                                                      \
   M(Temp, TempVal)                                                             \
   M(Constant, ConstantVal)                                                     \
@@ skipping 237 matching lines @@
   }
 
  private:
   const NativeBodyNode& ast_node_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeCallComp);
 };
 
 
 // Not simply an InstanceCall because it has somewhat more complicated
-// semantics: the value operand is preserved in a placeholder (the first
-// operand is a preallocated slot that can be used).
+// semantics: the value operand is preserved before the call.
 class StoreIndexedComp : public Computation {
  public:
   StoreIndexedComp(StoreIndexedNode* node,
-                   Value* placeholder,
                    Value* array,
                    Value* index,
                    Value* value)
       : ast_node_(*node),
-        placeholder_(placeholder),
         array_(array),
         index_(index),
         value_(value) { }
 
   DECLARE_COMPUTATION(StoreIndexed)
 
   // Accessors forwarded to the AST node.
   intptr_t node_id() const { return ast_node_.id(); }
   intptr_t token_index() const { return ast_node_.token_index(); }
 
-  Value* placeholder() const { return placeholder_; }
   Value* array() const { return array_; }
   Value* index() const { return index_; }
   Value* value() const { return value_; }
 
  private:
   const StoreIndexedNode& ast_node_;
-  Value* placeholder_;
   Value* array_;
   Value* index_;
   Value* value_;
 
   DISALLOW_COPY_AND_ASSIGN(StoreIndexedComp);
 };
 
 
 // Not simply an InstanceCall because it has somewhat more complicated
-// semantics: the value operand is preserved in a placeholder (the first
-// operand is a preallocate slot that can be used).
+// semantics: the value operand is preserved before the call.
 class InstanceSetterComp : public Computation {
  public:
   InstanceSetterComp(InstanceSetterNode* node,
-                     Value* placeholder,
                      Value* receiver,
                      Value* value)
       : ast_node_(*node),
-        placeholder_(placeholder),
         receiver_(receiver),
         value_(value) { }
 
   DECLARE_COMPUTATION(InstanceSetter)
 
   // Accessors forwarded to the AST node.
   intptr_t node_id() const { return ast_node_.id(); }
   intptr_t token_index() const { return ast_node_.token_index(); }
   const String& field_name() const { return ast_node_.field_name(); }
 
-  Value* placeholder() const { return placeholder_; }
   Value* receiver() const { return receiver_; }
   Value* value() const { return value_; }
 
  private:
   const InstanceSetterNode& ast_node_;
-  Value* placeholder_;
   Value* receiver_;
   Value* value_;
 
   DISALLOW_COPY_AND_ASSIGN(InstanceSetterComp);
 };
 
 
 #undef DECLARE_COMPUTATION
 
 
@@ skipping 265 matching lines @@
 #undef DECLARE_VISIT_INSTRUCTION
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor);
 };
 
 
 }  // namespace dart
 
 #endif  // VM_INTERMEDIATE_LANGUAGE_H_