Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: chrome/browser/password_manager/password_manager_unittest.cc

Issue 9586023: Fix memory failures in PasswordManager tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_unittest.cc
diff --git a/chrome/browser/password_manager/password_manager_unittest.cc b/chrome/browser/password_manager/password_manager_unittest.cc
index 0f5832b62b811124a53fb494b0868ce659586823..1fcbaa1d42e6be975c8250e39a77df553497ffd3 100644
--- a/chrome/browser/password_manager/password_manager_unittest.cc
+++ b/chrome/browser/password_manager/password_manager_unittest.cc
@@ -208,12 +208,16 @@ TEST_F(PasswordManagerTest, FormSeenThenLeftPage) {
manager()->OnPasswordFormsFound(observed); // The initial load.
manager()->OnPasswordFormsVisible(observed); // The initial layout.
+ PasswordForm empty_form(form);
+ empty_form.username_value = string16();
+ empty_form.password_value = string16();
content::LoadCommittedDetails details;
content::FrameNavigateParams params;
- params.password_form = form;
+ params.password_form = empty_form;
manager()->DidNavigateAnyFrame(details, params);
// No expected calls.
+ EXPECT_CALL(delegate_, AddSavePasswordInfoBar(_)).Times(0);
manager()->DidStopLoading();
}

Powered by Google App Engine
This is Rietveld 408576698